[GitHub] carbondata pull request #1629: [CARBONDATA-1714] Fixed Issue for Selection o...

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1629
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1995/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1629
 
    Build Failed with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/765/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1629
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2309/



---

[qiuchenjian-2]

Github user jatin9896 commented on the issue:

    https://github.com/apache/carbondata/pull/1629
 
    retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1629
 
    Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/790/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1629
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2335/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1629
 
    Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/798/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1629
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2024/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1629
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2031/



---

[qiuchenjian-2]

Github user jatin9896 commented on the issue:

    https://github.com/apache/carbondata/pull/1629
 
    @kumarvishal09 Please verify.


---

[qiuchenjian-2]

Github user kumarvishal09 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1629#discussion_r157701509
 
    --- Diff: hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonTableInputFormat.java ---
    @@ -804,7 +804,7 @@ public QueryModel getQueryModel(InputSplit inputSplit, TaskAttemptContext taskAt
         Expression filter = getFilterPredicates(configuration);
         boolean[] isFilterDimensions = new boolean[carbonTable.getDimensionOrdinalMax()];
         boolean[] isFilterMeasures =
    -        new boolean[carbonTable.getNumberOfMeasures(carbonTable.getTableName())];
    --- End diff --
   
    Can u please add comment why you are calling getAllMeasures() instead of getNumberOfMeasures(carbonTable.getTableName())


---

[qiuchenjian-2]

Github user jatin9896 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1629#discussion_r157711859
 
    --- Diff: hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonTableInputFormat.java ---
    @@ -804,7 +804,7 @@ public QueryModel getQueryModel(InputSplit inputSplit, TaskAttemptContext taskAt
         Expression filter = getFilterPredicates(configuration);
         boolean[] isFilterDimensions = new boolean[carbonTable.getDimensionOrdinalMax()];
         boolean[] isFilterMeasures =
    -        new boolean[carbonTable.getNumberOfMeasures(carbonTable.getTableName())];
    --- End diff --
   
    getNumberOfMeasures doesn't include column count which was dropped but it exists in measure list with invisible true whereas the getAllmeasures also include the recent dropped column as well.


---

[qiuchenjian-2]

Github user kumarvishal09 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1629#discussion_r157761421
 
    --- Diff: hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonTableInputFormat.java ---
    @@ -804,7 +804,7 @@ public QueryModel getQueryModel(InputSplit inputSplit, TaskAttemptContext taskAt
         Expression filter = getFilterPredicates(configuration);
         boolean[] isFilterDimensions = new boolean[carbonTable.getDimensionOrdinalMax()];
         boolean[] isFilterMeasures =
    -        new boolean[carbonTable.getNumberOfMeasures(carbonTable.getTableName())];
    --- End diff --
   
    Please add comment in the code :)


---

[qiuchenjian-2]

Github user jatin9896 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1629#discussion_r157790360
 
    --- Diff: hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonTableInputFormat.java ---
    @@ -804,7 +804,7 @@ public QueryModel getQueryModel(InputSplit inputSplit, TaskAttemptContext taskAt
         Expression filter = getFilterPredicates(configuration);
         boolean[] isFilterDimensions = new boolean[carbonTable.getDimensionOrdinalMax()];
         boolean[] isFilterMeasures =
    -        new boolean[carbonTable.getNumberOfMeasures(carbonTable.getTableName())];
    --- End diff --
   
    done please review.


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1629
 
    Build Failed with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/919/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1629
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2432/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1629
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2150/



---

[qiuchenjian-2]

Github user jatin9896 commented on the issue:

    https://github.com/apache/carbondata/pull/1629
 
    retest this please


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1629
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2446/



---

[qiuchenjian-2]

Github user jatin9896 commented on the issue:

    https://github.com/apache/carbondata/pull/1629
 
    retest this please


---