[GitHub] carbondata pull request #1630: [CARBONDATA-1826] Carbon 1.3.0 - Spark 2.2: D...

[qiuchenjian-2]

Github user manishgupta88 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1630#discussion_r156134688
 
    --- Diff: integration/spark-common/src/main/scala/org/apache/spark/util/CarbonReflectionUtils.scala ---
    @@ -175,6 +175,17 @@ object CarbonReflectionUtils {
         }
       }
     
    +  def getDescribeTableFormattedField[T: TypeTag : reflect.ClassTag](obj: T): Boolean = {
    +    var isFormatted: Boolean = false
    +    val im = rm.reflect(obj)
    +    for (m <- typeOf[T].members.filter(!_.isMethod)) {
    +      if (m.toString.contains("isFormatted")) {
    +        isFormatted = im.reflectField(m.asTerm).get.asInstanceOf[Boolean]
    --- End diff --
   
    Once the condition is satisfied, exit the loop....Also can you try to use find method here instead of using for loop..


---

[qiuchenjian-2]

Github user dhatchayani commented on the issue:

    https://github.com/apache/carbondata/pull/1630
 
    retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1630
 
    Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/651/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1630
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1882/



---

[qiuchenjian-2]

Github user manishgupta88 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1630#discussion_r156305867
 
    --- Diff: integration/spark-common/src/main/scala/org/apache/spark/util/CarbonReflectionUtils.scala ---
    @@ -175,6 +175,15 @@ object CarbonReflectionUtils {
         }
       }
     
    +  def getDescribeTableFormattedField[T: TypeTag : reflect.ClassTag](obj: T): Boolean = {
    +    var isFormatted: Boolean = false
    --- End diff --
   
    make it val


---

[qiuchenjian-2]

Github user manishgupta88 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1630#discussion_r156305910
 
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/strategy/DDLStrategy.scala ---
    @@ -134,17 +134,25 @@ class DDLStrategy(sparkSession: SparkSession) extends SparkStrategy {
             } else {
               throw new MalformedCarbonCommandException("Unsupported alter operation on hive table")
             }
    -      case desc@DescribeTableCommand(identifier, partitionSpec, isExtended)
    -        if CarbonEnv.getInstance(sparkSession).carbonMetastore
    -          .tableExists(identifier)(sparkSession) =>
    -        val resolvedTable =
    -          sparkSession.sessionState.executePlan(UnresolvedRelation(identifier)).analyzed
    -        val resultPlan = sparkSession.sessionState.executePlan(resolvedTable).executedPlan
    -        ExecutedCommandExec(
    -          CarbonDescribeFormattedCommand(
    -            resultPlan,
    -            plan.output,
    -            identifier)) :: Nil
    +      case desc@DescribeTableCommand(identifier, partitionSpec, isExtended) =>
    +        var isFormatted: Boolean = false
    --- End diff --
   
    make it val


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1630
 
    Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/660/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1630
 
    Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/663/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1630
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1891/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1630
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2226/



---

[qiuchenjian-2]

Github user dhatchayani commented on the issue:

    https://github.com/apache/carbondata/pull/1630
 
    retest sdv please


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1630
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2233/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1630
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2236/



---

[qiuchenjian-2]

Github user manishgupta88 commented on the issue:

    https://github.com/apache/carbondata/pull/1630
 
    LGTM


---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/1630


---