[GitHub] carbondata pull request #1649: Incorrect output on presto CLI while executin...

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1649
 
    Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1035/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1649
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2258/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1649
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2263/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1649
 
    Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1041/



---

[qiuchenjian-2]

Github user anubhav100 commented on the issue:

    https://github.com/apache/carbondata/pull/1649
 
    retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1649
 
    Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1064/



---

[qiuchenjian-2]

Github user chenliang613 commented on the issue:

    https://github.com/apache/carbondata/pull/1649
 
    @anubhav100  One small question : as per the jira description, need use multiple load to reproduce this issue, but your test case doesn't do multiple load.


---

[qiuchenjian-2]

Github user anubhav100 commented on the issue:

    https://github.com/apache/carbondata/pull/1649
 
    @chenliang613  1.jira title is not completely correct it just appears to the tester that it is because of multiple load only problem is that in operator on timestamp is not working correctly because timestamp was getting multiplied by 1000 twice when we are creating inexpression i updated the same in description as well
   
    2. we are using carbondatastorecreator to create store and it is using only core api so it is too difficult to do multiple loads so i added the test case for the exact scenario



---

[qiuchenjian-2]

Github user chenliang613 commented on the issue:

    https://github.com/apache/carbondata/pull/1649
 
    @anubhav100  ok, got it, no need to add multiple-load for this test case.
   
    Can you please fix this issue together in this pr , i ran PrestoAllDataTypeTest.scala, get the below error:
   
    java.lang.NullPointerException
    at org.apache.carbondata.presto.util.CarbonDataStoreCreator$.executeGraph(CarbonDataStoreCreator.scala:498)
    at org.apache.carbondata.presto.util.CarbonDataStoreCreator$.createCarbonStore(CarbonDataStoreCreator.scala:134)
    at org.apache.carbondata.presto.integrationtest.PrestoAllDataTypeTest.beforeAll(PrestoAllDataTypeTest.scala:40)
    at org.scalatest.BeforeAndAfterAll$class.beforeAll(BeforeAndAfterAll.scala:187)
    at org.apache.carbondata.presto.integrationtest.PrestoAllDataTypeTest.beforeAll(PrestoAllDataTypeTest.scala:28)
    at org.scalatest.BeforeAndAfterAll$class.run(BeforeAndAfterAll.scala:253)
    at org.apache.carbondata.presto.integrationtest.PrestoAllDataTypeTest.run(PrestoAllDataTypeTest.scala:28)
    at org.scalatest.tools.SuiteRunner.run(SuiteRunner.scala:55)
    at org.scalatest.tools.Runner$$anonfun$doRunRunRunDaDoRunRun$3.apply(Runner.scala:2563)
    at org.scalatest.tools.Runner$$anonfun$doRunRunRunDaDoRunRun$3.apply(Runner.scala:2557)
    at scala.collection.immutable.List.foreach(List.scala:381)
    at org.scalatest.tools.Runner$.doRunRunRunDaDoRunRun(Runner.scala:2557)
    at org.scalatest.tools.Runner$$anonfun$runOptionallyWithPassFailReporter$2.apply(Runner.scala:1044)
    at org.scalatest.tools.Runner$$anonfun$runOptionallyWithPassFailReporter$2.apply(Runner.scala:1043)
    at org.scalatest.tools.Runner$.withClassLoaderAndDispatchReporter(Runner.scala:2722)
    at org.scalatest.tools.Runner$.runOptionallyWithPassFailReporter(Runner.scala:1043)
    at org.scalatest.tools.Runner$.run(Runner.scala:883)
    at org.scalatest.tools.Runner.run(Runner.scala)
    at org.jetbrains.plugins.scala.testingSupport.scalaTest.ScalaTestRunner.runScalaTest2(ScalaTestRunner.java:138)
    at org.jetbrains.plugins.scala.testingSupport.scalaTest.ScalaTestRunner.main(ScalaTestRunner.java:28)


---

[qiuchenjian-2]

Github user anubhav100 commented on the issue:

    https://github.com/apache/carbondata/pull/1649
 
    @chenliang613 my pr #1695 which has the title 'Sparksql query result is not same as presto on same sql'  has already resolved this issue in latest master the reason you get error is pr #1695 get merged in between to the master branch but i did not rebased this branch with latest master since there was no merge conflict so you get the error logs but now i  rebased this branch with latest master please try running test cases once again it will work with out any error i already tested it


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1649
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2316/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1649
 
    Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1100/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1649
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2547/



---

[qiuchenjian-2]

Github user anubhav100 commented on the issue:

    https://github.com/apache/carbondata/pull/1649
 
    retest sdv please


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1649
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2548/



---

[qiuchenjian-2]

Github user chenliang613 commented on the issue:

    https://github.com/apache/carbondata/pull/1649
 
    LGTM


---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/1649


---