[GitHub] carbondata pull request #1658: [CARBONDATA-1680] Fixed Bug to show partition...

[qiuchenjian-2]

GitHub user SangeetaGulia opened a pull request:

    https://github.com/apache/carbondata/pull/1658

    [CARBONDATA-1680] Fixed Bug to show partition Ids for Hash Partition

    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [x] Any interfaces changed? No
     
     - [x] Any backward compatibility impacted? No
     
     - [x] Document update required? No
   
     - [x] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [x] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. (N/A)
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/SangeetaGulia/incubator-carbondata CARBONDATA-1680

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1658.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1658
   
----
commit 807474ea179efcc2528867221e039b66a9948ad7
Author: SangeetaGulia <[hidden email]>
Date:   2017-12-14T06:04:02Z

    Fixed Bug to show partition Ids for Hash Partition

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1658
 
    Build Failed with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/729/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1658
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1957/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1658
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1958/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1658
 
    Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/730/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1658
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2276/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1658
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2280/



---

[qiuchenjian-2]

Github user lionelcao commented on the issue:

    https://github.com/apache/carbondata/pull/1658
 
    Hi, For hash partition we only need to show number of partitions. Why need to show the ids?


---

[qiuchenjian-2]

Github user SangeetaGulia commented on the issue:

    https://github.com/apache/carbondata/pull/1658
 
    I have displayed the partition_ids due to the bug raised in this jira https://issues.apache.org/jira/browse/CARBONDATA-1680
   
    which says "Show Partition for Hash Partition doesn't display the partition id"


---

[qiuchenjian-2]

Github user lionelcao commented on the issue:

    https://github.com/apache/carbondata/pull/1658
 
    Hi @SangeetaGulia ,
    look into the first image in the jira, under the highlighted text, we said the alter partition operation is not supported for hash partition table. So we don't show the ids. I suggest to keep the origin design.
    Thanks for your contribution although : )


---

[qiuchenjian-2]

Github user SangeetaGulia commented on the issue:

    https://github.com/apache/carbondata/pull/1658
 
    Hi @lionelcao ,
    Is there any plan to support alter partition operation for hash partition table in future?


---

[qiuchenjian-2]

Github user sraghunandan commented on the issue:

    https://github.com/apache/carbondata/pull/1658
 
    @SangeetaGulia partition requirement is being rewritten to solve additional usecases.Pls refer CARBONDATA-1850. Please verify whether you fix would be required or not


---

[qiuchenjian-2]

Github user SangeetaGulia commented on the issue:

    https://github.com/apache/carbondata/pull/1658
 
    @sraghunandan I have found two related tasks:
    1) Create a system-level switch for supporting standard partition or carbon custom partition.
    2) Support drop partition in carbon
   
    So are we continuing support of custom partitions? and if yes then are we going to provide the support of drop partition for hash partition table?
   
   
   
   
   
    Support drop partition in carbon
    --
   
   
   
   
    Support drop partition in carbon
    --
   
   
   
   
    Support drop partition in carbon
    --
   
   
   
   
    Support drop partition in carbon
    --
   
   
    Support drop partition in carbon
    --
   
   
   



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1658
 
    Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/944/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1658
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2173/



---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/1658


---