[GitHub] carbondata pull request #1661: Fixed incorrect partitionCount on Alter Parti...

[qiuchenjian-2]

GitHub user SangeetaGulia opened a pull request:

    https://github.com/apache/carbondata/pull/1661

    Fixed incorrect partitionCount on Alter Partition Table

    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [x] Any interfaces changed? No
     
     - [x] Any backward compatibility impacted? No
     
     - [x] Document update required? No
   
     - [x] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [x] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. (N/A)
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/SangeetaGulia/incubator-carbondata CARBONDATA-1678

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1661.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1661
   
----
commit 4d23490759cef49f7dddb94efb4bec1ef685d0d8
Author: SangeetaGulia <[hidden email]>
Date:   2017-12-14T11:40:09Z

    Fixed incorrect partitionCount on Alter Partition Table

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1661
 
    Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/738/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1661
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1967/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1661
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2287/



---

[qiuchenjian-2]

Github user SangeetaGulia commented on the issue:

    https://github.com/apache/carbondata/pull/1661
 
    retest this please.


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1661
 
    Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/759/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1661
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1989/



---

[qiuchenjian-2]

Github user lionelcao commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1661#discussion_r157131588
 
    --- Diff: integration/spark-common/src/main/scala/org/apache/spark/util/PartitionUtils.scala ---
    @@ -113,7 +113,8 @@ object PartitionUtils {
         }
     
         if (partitionId == 0) {
    -      partitionInfo.addPartition(splitInfo.size)
    +      val addedPartitionList = PartitionUtils.getListInfo(splitInfo.mkString(","))
    --- End diff --
   
    Looks like `add partition` of list partition table can only support string, but not string group.
    If need to support string group, splitInfo should be List[List[String]] instead of List[String].
    Could you also change other places to support this feature and add test case?


---

[qiuchenjian-2]

Github user SangeetaGulia commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1661#discussion_r157135341
 
    --- Diff: integration/spark-common/src/main/scala/org/apache/spark/util/PartitionUtils.scala ---
    @@ -113,7 +113,8 @@ object PartitionUtils {
         }
     
         if (partitionId == 0) {
    -      partitionInfo.addPartition(splitInfo.size)
    +      val addedPartitionList = PartitionUtils.getListInfo(splitInfo.mkString(","))
    --- End diff --
   
    Add partition does support String group. The problem in this bug is, when you are trying to add these two partitions "'SAUDI ARABIA,(VIETNAM,RUSSIA,UNITED KINGDOM,UNITED STATES)'" then splitInfo variable takes it as one partition and increment partition count by 1. To get the correct partitions out of it, we need to extract the list out of the splitList.
   
    As this is a sequence based test case, where the problem is encountered when we  "show partition" after "alter table to add partition", So is it alright to add its test case to TestAlterPartitionTable.scala?
   
   
   
   



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1661
 
    Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/772/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1661
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2003/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1661
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2318/



---

[qiuchenjian-2]

Github user SangeetaGulia commented on the issue:

    https://github.com/apache/carbondata/pull/1661
 
    @lionelcao Please review. I have added the test case.


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1661
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2171/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1661
 
    Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/942/



---

[qiuchenjian-2]

Github user SangeetaGulia commented on the issue:

    https://github.com/apache/carbondata/pull/1661
 
    retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1661
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2650/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1661
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1418/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1661
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3055/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1661
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4299/



---