[GitHub] carbondata pull request #1666: table status timezone problem fix

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1666
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2383/



---

[qiuchenjian-2]

Github user mohammadshahidkhan commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1666#discussion_r157427169
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/statusmanager/LoadMetadataDetails.java ---
    @@ -211,25 +234,32 @@ public long getLoadStartTimeAsLong() {
        * @return
        */
       private long convertTimeStampToLong(String factTimeStamp) {
    --- End diff --
   
    This function getTimeStamp returns value in nano second and returns in mili second


---

[qiuchenjian-2]

Github user mohammadshahidkhan commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1666#discussion_r157428485
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/statusmanager/LoadMetadataDetails.java ---
    @@ -211,25 +234,32 @@ public long getLoadStartTimeAsLong() {
        * @return
        */
       private long convertTimeStampToLong(String factTimeStamp) {
    -    SimpleDateFormat parser = new SimpleDateFormat(CarbonCommonConstants.CARBON_TIMESTAMP_MILLIS);
    -    Date dateToStr = null;
         try {
    -      dateToStr = parser.parse(factTimeStamp);
    -      return dateToStr.getTime();
    -    } catch (ParseException e) {
    -      LOGGER.error("Cannot convert" + factTimeStamp + " to Time/Long type value" + e.getMessage());
    -      parser = new SimpleDateFormat(CarbonCommonConstants.CARBON_TIMESTAMP);
    +      // for new loads the factTimeStamp will be long string
    --- End diff --
   
    Fixed


---

[qiuchenjian-2]

Github user mohammadshahidkhan commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1666#discussion_r157428609
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/statusmanager/LoadMetadataDetails.java ---
    @@ -241,26 +248,28 @@ private long convertTimeStampToLong(String factTimeStamp) {
        * @return
        */
       public Long getTimeStamp(String loadStartTime) {
    -    Date dateToStr = null;
         try {
    -      dateToStr = parser.parse(loadStartTime);
    -      return dateToStr.getTime() * 1000;
    -    } catch (ParseException e) {
    -      LOGGER.error("Cannot convert" + loadStartTime + " to Time/Long type value" + e.getMessage());
    -      return null;
    +      // for new loads the factTimeStamp will be long string
    --- End diff --
   
    fixed


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1666
 
    Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/864/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1666
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2089/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1666
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2387/



---

[qiuchenjian-2]

Github user mohammadshahidkhan commented on the issue:

    https://github.com/apache/carbondata/pull/1666
 
    retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1666
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2117/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1666
 
    Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/893/



---

[qiuchenjian-2]

Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/1666
 
    LGTM


---

[qiuchenjian-2]

Github user manishgupta88 commented on the issue:

    https://github.com/apache/carbondata/pull/1666
 
    LGTM


---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/1666


---