[GitHub] carbondata pull request #1693: [CARBONDATA-1909] Load is failing during inse...

[qiuchenjian-2]

GitHub user ManoharVanam opened a pull request:

    https://github.com/apache/carbondata/pull/1693

    [CARBONDATA-1909] Load is failing during insert into operation when load is concurrently done to source table

    Load is failing during insert into operation when load is concurrently done to source table
   
    Scenario:
    Client1:
    1. Create source table
    2. load big data
   
    Client2:
    1. create table t1
    2. insert into t1 select * from  source table   - load fails
   
    Data Load:
    Step1 : Dictionary Generarion
    Step2: Loading data
   
    Assume 100 records is read from source table using select statement, but when execution reaches step2, 50 more records has been added to source table. So when select happens on source table during data loading , it gets new record for which dictionary is not generated. So there is inconsistency.
   
    Solution :
    To solve this issue we persisted dataframe, so that select will not get fired for second time. But this has some performance impact. So we are providing configuration to enable persist, if user wants to perform this kind of scenario he can enable this configuration at cost of performance.
   
    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
   
     - [ ] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ManoharVanam/incubator-carbondata pr1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1693.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1693
   
----
commit d9c2f21a4db8115cf97cb6c073e44d43bc90d9b8
Author: Manohar <manohar.crazy09@...>
Date:   2017-12-20T09:39:45Z

    Load is failing during insert into operation when load is concurrently done to source table

----


---

[qiuchenjian-2]

Github user ManoharVanam commented on the issue:

    https://github.com/apache/carbondata/pull/1693
 
    retest this please


---

[qiuchenjian-2]

Github user ManoharVanam commented on the issue:

    https://github.com/apache/carbondata/pull/1693
 
    retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1693
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2272/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1693
 
    Build Failed with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1051/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1693
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2670/



---

[qiuchenjian-2]

Github user ManoharVanam commented on the issue:

    https://github.com/apache/carbondata/pull/1693
 
    retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1693
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1330/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1693
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2565/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1693
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1669/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1693
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2902/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1693
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3032/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1693
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1807/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1693
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3038/



---

[qiuchenjian-2]

Github user ManoharVanam commented on the issue:

    https://github.com/apache/carbondata/pull/1693
 
    retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1693
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3044/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1693
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1813/



---

[qiuchenjian-2]

Github user gvramana commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1693#discussion_r163241946
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java ---
    @@ -864,6 +864,18 @@
       public static final String CARBON_MERGE_SORT_PREFETCH = "carbon.merge.sort.prefetch";
       public static final String CARBON_MERGE_SORT_PREFETCH_DEFAULT = "true";
     
    +  /**
    +   * to determine to use the rdd persist or not for insert query.
    --- End diff --
   
    Please write clear comment, when this should be used and what is the impact if not used, why default value is false?


---

[qiuchenjian-2]

Github user ManoharVanam commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1693#discussion_r163250438
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java ---
    @@ -864,6 +864,18 @@
       public static final String CARBON_MERGE_SORT_PREFETCH = "carbon.merge.sort.prefetch";
       public static final String CARBON_MERGE_SORT_PREFETCH_DEFAULT = "true";
     
    +  /**
    +   * to determine to use the rdd persist or not for insert query.
    --- End diff --
   
    done


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1693
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1836/



---