[GitHub] carbondata pull request #1697: [CARBONDATA-1719] Fixed bug to handle data in...

[qiuchenjian-2]

GitHub user SangeetaGulia opened a pull request:

    https://github.com/apache/carbondata/pull/1697

    [CARBONDATA-1719] Fixed bug to handle data inconsistency on concurrent data load and pre-aggregate table creation

    Problem: On concurrent data load and pre-aggregate table creation, datamap was not getting populated with the load data even after data load completes.
   
    This PR fix this issue.
   
    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [x] Any interfaces changed? No
     
     - [x] Any backward compatibility impacted? No
     
     - [x] Document update required? No
   
     - [x] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
        Tested the functionality on Two node cluster      
     
     - [x] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. (N/A)
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/SangeetaGulia/incubator-carbondata CARBONDATA-1719

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1697.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1697
   
----
commit 7e002e25e88516aed96fab82dac2afb9cba8fb7a
Author: SangeetaGulia <sangeeta.gulia@...>
Date:   2017-12-20T12:32:51Z

    Fixed bug to handle data inconsistency on concurrent data load and pre-aggregate table creation

----


---

[qiuchenjian-2]

Github user kunal642 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1697#discussion_r158041809
 
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateListeners.scala ---
    @@ -38,7 +40,10 @@ object LoadPostAggregateListener extends OperationEventListener {
         val loadEvent = event.asInstanceOf[LoadTablePreStatusUpdateEvent]
         val sparkSession = loadEvent.sparkSession
         val carbonLoadModel = loadEvent.carbonLoadModel
    -    val table = carbonLoadModel.getCarbonDataLoadSchema.getCarbonTable
    +    val metastore = CarbonEnv.getInstance(sparkSession).carbonMetastore
    +    carbonLoadModel.getTableName
    --- End diff --
   
    i think this was added by mistake.. Please remove


---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1697#discussion_r158582511
 
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateListeners.scala ---
    @@ -38,7 +40,9 @@ object LoadPostAggregateListener extends OperationEventListener {
         val loadEvent = event.asInstanceOf[LoadTablePreStatusUpdateEvent]
         val sparkSession = loadEvent.sparkSession
         val carbonLoadModel = loadEvent.carbonLoadModel
    -    val table = carbonLoadModel.getCarbonDataLoadSchema.getCarbonTable
    +    val metastore = CarbonEnv.getInstance(sparkSession).carbonMetastore
    +    val table = metastore.lookupRelation(Some(carbonLoadModel.getDatabaseName),
    --- End diff --
   
    You can use CarbonEnv to get CarbonTable


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1697
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2322/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1697
 
    Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1109/



---

[qiuchenjian-2]

Github user SangeetaGulia commented on the issue:

    https://github.com/apache/carbondata/pull/1697
 
    retest this please



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1697
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2554/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1697
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2327/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1697
 
    Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1117/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1697
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2336/



---

[qiuchenjian-2]

Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/1697
 
    retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1697
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2444/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1697
 
    Build Failed with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1224/



---

[qiuchenjian-2]

Github user kumarvishal09 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1697#discussion_r159391691
 
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateListeners.scala ---
    @@ -161,7 +163,8 @@ object PreAggregateDataTypeChangePreListener extends OperationEventListener {
         }
         if (carbonTable.isChildDataMap) {
           throw new UnsupportedOperationException(
    -        s"Cannot change data type for columns in pre-aggregate table ${ carbonTable.getDatabaseName
    +        s"Cannot change data type for columns in pre-aggregate table ${
    --- End diff --
   
    Please avoid unnecessary changes.


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1697
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2509/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1697
 
    Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1286/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1697
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2675/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1697
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2517/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1697
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2676/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1697
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2679/



---