[GitHub] carbondata pull request #1704: [CARBONDATA-1918] Incorrect data is displayed...

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1704
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2021/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1704
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3258/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1704
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3213/



---

[qiuchenjian-2]

Github user kumarvishal09 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1704#discussion_r165368872
 
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/hive/CarbonAnalysisRules.scala ---
    @@ -206,6 +208,30 @@ case class CarbonIUDAnalysisRule(sparkSession: SparkSession) extends Rule[Logica
               table)
         }
       }
    +
    +
    +  /**
    +   * This method will check whether the data type of new value is supported or not
    +   * For example, arrayType is not supported
    +   */
    +  def checkForUnsupportedType(selectStmt: String): Unit = {
    +    // selectStmt will have "select 'newValue' from table"
    +    // we can validate the new value by executing the select query
    +    val sel = selectStmt.substring(0, selectStmt.lastIndexOf("from")).trim;
    --- End diff --
   
    Better not to add this type of check ,
    replace dataSet = sparkSession.sql(selectStmt).collect() directly for any case it will execute and get the rows


---

[qiuchenjian-2]

Github user kumarvishal09 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1704#discussion_r165369872
 
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/hive/CarbonAnalysisRules.scala ---
    @@ -206,6 +208,30 @@ case class CarbonIUDAnalysisRule(sparkSession: SparkSession) extends Rule[Logica
               table)
         }
       }
    +
    +
    +  /**
    +   * This method will check whether the data type of new value is supported or not
    +   * For example, arrayType is not supported
    +   */
    +  def checkForUnsupportedType(selectStmt: String): Unit = {
    +    // selectStmt will have "select 'newValue' from table"
    +    // we can validate the new value by executing the select query
    +    val sel = selectStmt.substring(0, selectStmt.lastIndexOf("from")).trim;
    --- End diff --
   
    Instead of getting from the data set , can we get a logical plan and check the data type


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1704
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2207/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1704
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3447/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1704
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3309/



---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/1704


---