[GitHub] carbondata pull request #1714: [CARBONDATA-1932] Add version for CarbonData

[qiuchenjian-2]

Github user zzcclp commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1714#discussion_r158620368
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java ---
    @@ -1108,6 +1114,11 @@
        */
       public static final String CARBON_DATA_FILE_DEFAULT_VERSION = "V3";
     
    +  /**
    +   * current CarbonData version
    +   */
    +  public static final String CARBONDATA_DEFAULT_VERSION = "1.3.0-SNAPSHOT";
    --- End diff --
   
    I think you can do it as the same as spark, it generates a file called 'spark-version-info.properties' when build, and then read version information from this file at runtime.


---

[qiuchenjian-2]

Github user xubo245 commented on the issue:

    https://github.com/apache/carbondata/pull/1714
 
    When we test carbondata performance, we need know spark verison and carbondata version, like in concurrency test case.
    Spark have version infomation in code, but carbondata no this. So we need implement the function.


---

[qiuchenjian-2]

Github user xubo245 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1714#discussion_r158701971
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java ---
    @@ -1108,6 +1114,11 @@
        */
       public static final String CARBON_DATA_FILE_DEFAULT_VERSION = "V3";
     
    +  /**
    +   * current CarbonData version
    +   */
    +  public static final String CARBONDATA_DEFAULT_VERSION = "1.3.0-SNAPSHOT";
    --- End diff --
   
    Ok, I will try. Thank you.


---

[qiuchenjian-2]

Github user xubo245 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1714#discussion_r158704044
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java ---
    @@ -1108,6 +1114,11 @@
        */
       public static final String CARBON_DATA_FILE_DEFAULT_VERSION = "V3";
     
    +  /**
    +   * current CarbonData version
    +   */
    +  public static final String CARBONDATA_DEFAULT_VERSION = "1.3.0-SNAPSHOT";
    --- End diff --
   
    @zzcclp It has a little complexity in spark, is there better solution?


---

[qiuchenjian-2]

Github user zzcclp commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1714#discussion_r158714905
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java ---
    @@ -1108,6 +1114,11 @@
        */
       public static final String CARBON_DATA_FILE_DEFAULT_VERSION = "V3";
     
    +  /**
    +   * current CarbonData version
    +   */
    +  public static final String CARBONDATA_DEFAULT_VERSION = "1.3.0-SNAPSHOT";
    --- End diff --
   
    I think it's a good way to do like spark, it's not complexity , I can help you to implement this.


---

[qiuchenjian-2]

Github user xubo245 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1714#discussion_r158779576
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java ---
    @@ -1108,6 +1114,11 @@
        */
       public static final String CARBON_DATA_FILE_DEFAULT_VERSION = "V3";
     
    +  /**
    +   * current CarbonData version
    +   */
    +  public static final String CARBONDATA_DEFAULT_VERSION = "1.3.0-SNAPSHOT";
    --- End diff --
   
    Ok, you can do it.


---

[qiuchenjian-2]

Github user xubo245 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1714#discussion_r158782714
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java ---
    @@ -1108,6 +1114,11 @@
        */
       public static final String CARBON_DATA_FILE_DEFAULT_VERSION = "V3";
     
    +  /**
    +   * current CarbonData version
    +   */
    +  public static final String CARBONDATA_DEFAULT_VERSION = "1.3.0-SNAPSHOT";
    --- End diff --
   
    @zzcclp  I assign the jira to you, and close this PR.


---

[qiuchenjian-2]

Github user xubo245 closed the pull request at:

    https://github.com/apache/carbondata/pull/1714


---

[qiuchenjian-2]

GitHub user xubo245 reopened a pull request:

    https://github.com/apache/carbondata/pull/1714

    [CARBONDATA-1932] Add version for CarbonData

    Add version for CarbonData
   
    Are there any other good idea for CarbonData version?
   
    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
   
     - [ ] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/xubo245/carbondata addVersion

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1714.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1714
   
----
commit 4a70571974bcc1e4b4ea90d1b9c8fd1b945ffa8c
Author: xubo245 <601450868@...>
Date:   2017-12-22T09:59:39Z

    [CARBONDATA-1932] Add version for CarbonData
   
    Add version for CarbonData

commit dbb3318aabd64f2090243af6fa87f96ce6c8469c
Author: xubo245 <601450868@...>
Date:   2017-12-23T01:49:41Z

    remove some test case and change the comment

----


---

[qiuchenjian-2]

Github user xubo245 commented on the issue:

    https://github.com/apache/carbondata/pull/1714
 
     I assign the jira to @zzcclp , and close this PR.


---

[qiuchenjian-2]

Github user xubo245 closed the pull request at:

    https://github.com/apache/carbondata/pull/1714


---