[GitHub] carbondata pull request #1722: [CARBONDATA-1755] Fixed bug occuring on curre...

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1722
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1339/



---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1722#discussion_r160079943
 
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/mutation/CarbonProjectForUpdateCommand.scala ---
    @@ -52,6 +53,13 @@ private[sql] case class CarbonProjectForUpdateCommand(
           return Seq.empty
         }
         val carbonTable = CarbonEnv.getCarbonTable(databaseNameOp, tableName)(sparkSession)
    +    val isLoadInProgress = SegmentStatusManager.checkIfAnyLoadInProgressForTable(carbonTable)
    +    if (isLoadInProgress) {
    +      LOGGER.error("Cannot run data loading and update on same table concurrently. Please wait"
    +                   + " for load to finish")
    +      throw new Exception("Cannot run data loading and update on same table concurrently. " +
    --- End diff --
   
    Use the `ConcurrentOperationException` added in #1711


---

[qiuchenjian-2]

Github user SangeetaGulia commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1722#discussion_r160086580
 
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/mutation/CarbonProjectForUpdateCommand.scala ---
    @@ -52,6 +53,13 @@ private[sql] case class CarbonProjectForUpdateCommand(
           return Seq.empty
         }
         val carbonTable = CarbonEnv.getCarbonTable(databaseNameOp, tableName)(sparkSession)
    +    val isLoadInProgress = SegmentStatusManager.checkIfAnyLoadInProgressForTable(carbonTable)
    +    if (isLoadInProgress) {
    +      LOGGER.error("Cannot run data loading and update on same table concurrently. Please wait"
    +                   + " for load to finish")
    +      throw new Exception("Cannot run data loading and update on same table concurrently. " +
    --- End diff --
   
    @jackylk I will update this code once #1711 will be merged.


---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1722#discussion_r160090617
 
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/mutation/CarbonProjectForUpdateCommand.scala ---
    @@ -52,6 +53,13 @@ private[sql] case class CarbonProjectForUpdateCommand(
           return Seq.empty
         }
         val carbonTable = CarbonEnv.getCarbonTable(databaseNameOp, tableName)(sparkSession)
    +    val isLoadInProgress = SegmentStatusManager.checkIfAnyLoadInProgressForTable(carbonTable)
    +    if (isLoadInProgress) {
    +      LOGGER.error("Cannot run data loading and update on same table concurrently. Please wait"
    +                   + " for load to finish")
    +      throw new Exception("Cannot run data loading and update on same table concurrently. " +
    --- End diff --
   
    #1711 is merged


---

[qiuchenjian-2]

Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/1722
 
    retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1722
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2640/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1722
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1415/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1722
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2647/



---

[qiuchenjian-2]

Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/1722
 
    LGTM


---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/1722


---