[GitHub] carbondata pull request #1758: [CARBONDATA-1978] Handled preaggregate issues...

[qiuchenjian-2]

GitHub user kunal642 opened a pull request:

    https://github.com/apache/carbondata/pull/1758

    [CARBONDATA-1978] Handled preaggregate issues with hive metastore

    During creation of TableInfo from hivemetastore the DataMapSchemas and the columns DataTypes are not converted to the appropriate child classes due to which data types not supported exception is thrown
   
    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [X] Any interfaces changed?
     No
     - [X] Any backward compatibility impacted?
     No
     - [X] Document update required?
    No
     - [X] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kunal642/carbondata hivemetastore_preagg

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1758.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1758
   
----
commit a90f8b5aaeb3c628293164291ee7f2ea591fba12
Author: kunal642 <kunalkapoor642@...>
Date:   2018-01-03T13:47:53Z

    handled preaggregate issues with hive metastore

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1758
 
    Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1290/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1758
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2520/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1758
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2687/



---

[qiuchenjian-2]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1758#discussion_r160105398
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/schema/table/CarbonTable.java ---
    @@ -132,12 +134,40 @@ private CarbonTable() {
         this.tablePrimitiveDimensionsMap = new HashMap<String, List<CarbonDimension>>();
       }
     
    +  /**
    +   * During creation of TableInfo from hivemetastore the DataMapSchemas and the columns
    +   * DataTypes are not converted to the appropriate child classes.
    +   *
    +   * This method will cast the same to the appropriate classes
    +   *
    +   * @param tableInfo
    +   */
    +  private static void updateTableInfo(TableInfo tableInfo) {
    +    if (Boolean.parseBoolean(CarbonProperties.getInstance().getProperty(
    +        CarbonCommonConstants.ENABLE_HIVE_SCHEMA_META_STORE))) {
    --- End diff --
   
    Irrespective enabling hivemetastore better always do this conversion here only. Remove this conversion from other places


---

[qiuchenjian-2]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1758#discussion_r160137111
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/schema/table/CarbonTable.java ---
    @@ -132,11 +133,42 @@ private CarbonTable() {
         this.tablePrimitiveDimensionsMap = new HashMap<String, List<CarbonDimension>>();
       }
     
    +  /**
    +   * During creation of TableInfo from hivemetastore the DataMapSchemas and the columns
    +   * DataTypes are not converted to the appropriate child classes.
    +   *
    +   * This method will cast the same to the appropriate classes
    +   *
    +   * @param tableInfo
    +   */
    +  private static void updateTableInfo(TableInfo tableInfo) {
    +    List<DataMapSchema> dataMapSchemas = new ArrayList<>();
    +    for (DataMapSchema dataMapSchema : tableInfo.getDataMapSchemaList()) {
    --- End diff --
   
    Similar code is present in `ThriftWrapperSchemaConverterImpl` also right? Is it possible to remove from there?



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1758
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2638/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1758
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2799/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1758
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1409/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1758
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2645/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1758
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1414/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1758
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1486/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1758
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2719/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1758
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1488/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1758
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2847/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1758
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2721/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1758
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2848/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1758
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1493/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1758
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2726/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1758
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1494/



---