[GitHub] carbondata pull request #1760: [CARBONDATA-1979] ][IMPLICIT COLUMN] Modified...

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #1760: [CARBONDATA-1979] ][IMPLICIT COLUMN] Modified...

qiuchenjian-2
GitHub user rahulforallp opened a pull request:

    https://github.com/apache/carbondata/pull/1760

    [CARBONDATA-1979] ][IMPLICIT COLUMN] Modified implicit column filtering logic to directly validate the blo…

    …cklet ID as after driver pruning valid blocklets are identified and tasks are divided based on blocklets
   
    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
   
     - [ ] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rahulforallp/incubator-carbondata implicit_column

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1760.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1760
   
----
commit 4df91bdf5608c280cd4c3f3320ddcb957aa496f2
Author: rahulforallp <rahul.kumar@...>
Date:   2018-01-03T09:51:37Z

    Modified implicit column filtering logic to directly validate the blocklet ID as after driver pruning valid blocklets are identified and tasks are divided based on blocklets

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1760: [CARBONDATA-1979] ][IMPLICIT COLUMN] Modified implic...

qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1760
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2533/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1760: [CARBONDATA-1979] ][IMPLICIT COLUMN] Modified implic...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1760
 
    Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1306/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1760: [CARBONDATA-1979] ][IMPLICIT COLUMN] Modified implic...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1760
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2697/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1760: [CARBONDATA-1979] ][IMPLICIT COLUMN] Modified implic...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user manishgupta88 commented on the issue:

    https://github.com/apache/carbondata/pull/1760
 
    LGTM


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #1760: [CARBONDATA-1979] ][IMPLICIT COLUMN] Modified...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/1760


---