[GitHub] carbondata pull request #1770: [CARBONDATA-1994] Remove CarbonInputFormat

[qiuchenjian-2]

Github user mohammadshahidkhan commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1770#discussion_r161200792
 
    --- Diff: integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/dblocation/DBLocationCarbonTableTestCase.scala ---
    @@ -44,6 +44,24 @@ class DBLocationCarbonTableTestCase extends QueryTest with BeforeAndAfterAll {
         sql("drop database if exists carbon cascade")
       }
     
    +  //TODO fix this test case
    +  test("Update operation on carbon table with insert into") {
    --- End diff --
   
    I think here only the method got placed from one place to another no code change


---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1770#discussion_r161228361
 
    --- Diff: integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/dblocation/DBLocationCarbonTableTestCase.scala ---
    @@ -44,6 +44,24 @@ class DBLocationCarbonTableTestCase extends QueryTest with BeforeAndAfterAll {
         sql("drop database if exists carbon cascade")
       }
     
    +  //TODO fix this test case
    +  test("Update operation on carbon table with insert into") {
    --- End diff --
   
    yes, I think this testcase fails sometimes because of the order, I change the order of the testcase to avoid the failure.


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1770
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2734/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1770
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1502/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1770
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2861/



---

[qiuchenjian-2]

Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/1770
 
    @ravipesala I have fixed it now


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1770
 
    LGTM


---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/1770


---