[GitHub] carbondata pull request #1771: [HOTFIX] Fix exception handling in PartitionM...

[qiuchenjian-2]

GitHub user jackylk opened a pull request:

    https://github.com/apache/carbondata/pull/1771

    [HOTFIX] Fix exception handling in PartitionMapFileStore

    Exception should not be ignored in PartitionMapFileStore.java, it should be thrown instead.
   
     - [X] Any interfaces changed?
     No
     - [X] Any backward compatibility impacted?
     No
     - [X] Document update required?
    No
     - [X] Testing done
    No logic is changed
     - [X] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
    NA

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jackylk/incubator-carbondata throw_ioexception

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1771.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1771
   
----
commit 30f36867f37f4e46f4e57a80658347ef34e6cb61
Author: Jacky Li <jacky.likun@...>
Date:   2018-01-07T02:58:54Z

    throw IOException

----


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1771
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2776/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1771
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1379/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1771
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2614/



---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1771#discussion_r160041526
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/PartitionMapFileStore.java ---
    @@ -206,10 +206,10 @@ private PartitionMapper readPartitionMap(String partitionMapPath) {
               Charset.forName(CarbonCommonConstants.DEFAULT_CHARSET));
           buffReader = new BufferedReader(inStream);
           partitionMapper = gsonObjectToRead.fromJson(buffReader, PartitionMapper.class);
    -    } catch (IOException e) {
    -      return null;
    --- End diff --
   
    Here is the modification, should not ignore the exception


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1771
 
    LGTM, But usually better hotfixes only do for build failures like compilation or test fails, not for review comments.  In case of review comment handling better compine mutilple and raise a PR.


---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/1771


---