[GitHub] carbondata pull request #1772: [CARBONDATA-1995] Unify all writer steps and ...

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1772
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2966/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1772
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2957/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1772
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1728/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1772
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2044/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1772
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3284/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1772
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2058/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1772
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3295/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1772
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3248/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1772
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2112/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1772
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3348/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1772
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3372/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1772
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2136/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1772
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3268/



---

[qiuchenjian-2]

Github user QiangCai commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1772#discussion_r165287316
 
    --- Diff: processing/src/main/java/org/apache/carbondata/processing/loading/steps/WriterProcessorStepImpl.java ---
    @@ -271,37 +262,18 @@ private CarbonRow convertRow(CarbonRow row) throws KeyGenException {
       }
     
       private void processBatch(CarbonRowBatch batch, CarbonFactHandler dataHandler, int iteratorIndex)
    -      throws CarbonDataLoadingException {
    -    try {
    -      while (batch.hasNext()) {
    -        CarbonRow row = batch.next();
    -        CarbonRow converted = convertRow(row);
    -        dataHandler.addDataToStore(converted);
    -        readCounter[iteratorIndex]++;
    +  {
    +    while (batch.hasNext()) {
    +      CarbonRow row;
    +      if (noSort) {
    --- End diff --
   
    move 'if' statement to the outside of 'while' loop


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1772
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2165/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1772
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3402/



---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1772#discussion_r165385686
 
    --- Diff: processing/src/main/java/org/apache/carbondata/processing/loading/steps/WriterProcessorStepImpl.java ---
    @@ -271,37 +262,18 @@ private CarbonRow convertRow(CarbonRow row) throws KeyGenException {
       }
     
       private void processBatch(CarbonRowBatch batch, CarbonFactHandler dataHandler, int iteratorIndex)
    -      throws CarbonDataLoadingException {
    -    try {
    -      while (batch.hasNext()) {
    -        CarbonRow row = batch.next();
    -        CarbonRow converted = convertRow(row);
    -        dataHandler.addDataToStore(converted);
    -        readCounter[iteratorIndex]++;
    +  {
    +    while (batch.hasNext()) {
    +      CarbonRow row;
    +      if (noSort) {
    --- End diff --
   
    ok, fixed


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1772
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2185/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1772
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3423/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1772
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3290/



---