[GitHub] carbondata pull request #1783: [CARBONDATA-2013] executing alter query resul...

[qiuchenjian-2]

GitHub user kushalsaha opened a pull request:

    https://github.com/apache/carbondata/pull/1783

    [CARBONDATA-2013] executing alter query results that table can not found in database

    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [ ] Any interfaces changed?
     No
     - [ ] Any backward compatibility impacted?
     No
     - [ ] Document update required?
    No
     - [ ] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
          Yes
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kushalsaha/carbondata 4Jan_DTS3404

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1783.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1783
   
----
commit 8e21c58e0b739ae43bf8f2583d35b133d13443d0
Author: kushalsaha <kushalsaha1988@...>
Date:   2018-01-09T17:11:10Z

    rename table issue

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1783
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1436/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1783
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2809/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1783
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2670/



---

[qiuchenjian-2]

Github user kushalsaha commented on the issue:

    https://github.com/apache/carbondata/pull/1783
 
    retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1783
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1439/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1783
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2673/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1783
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1446/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1783
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2680/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1783
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2817/



---

[qiuchenjian-2]

Github user kushalsaha commented on the issue:

    https://github.com/apache/carbondata/pull/1783
 
    retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1783
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1487/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1783
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2720/



---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1783#discussion_r161244237
 
    --- Diff: integration/spark2/src/test/scala/org/apache/spark/carbondata/restructure/vectorreader/AddColumnTestCases.scala ---
    @@ -656,6 +656,19 @@ class AddColumnTestCases extends Spark2QueryTest with BeforeAndAfterAll {
         sql("drop table if exists preagg1")
       }
     
    +  test("test rename parquet table") {
    +    sql("drop table if exists renameParquetTable")
    +    sql("drop table if exists new_renameParquetTable")
    +    sql("create table renameParquetTable (id int,time string) row format delimited fields terminated by ',' stored as textfile ")
    --- End diff --
   
    it is text file table, not parquet, right?


---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1783#discussion_r161244611
 
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/strategy/StreamingTableStrategy.scala ---
    @@ -59,7 +59,8 @@ private[sql] class StreamingTableStrategy(sparkSession: SparkSession) extends Sp
               new TableIdentifier(model.tableName, model.databaseName),
               "Alter table change datatype")
             Nil
    -      case AlterTableRenameCommand(oldTableIdentifier, _, _) =>
    +      case AlterTableRenameCommand(
    +      oldTableIdentifier, _, _) if (isCarbonStreamingTable(oldTableIdentifier)) =>
    --- End diff --
   
    Why this if check is needed, `rejectIfStreamingTable` checks whether it is streaming table already.
    Please describe the bug in PR description, otherwise not sure what bug it is.


---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1783#discussion_r161244262
 
    --- Diff: integration/spark2/src/test/scala/org/apache/spark/carbondata/restructure/vectorreader/AddColumnTestCases.scala ---
    @@ -656,6 +656,19 @@ class AddColumnTestCases extends Spark2QueryTest with BeforeAndAfterAll {
         sql("drop table if exists preagg1")
       }
     
    +  test("test rename parquet table") {
    --- End diff --
   
    it is text file table, not parquet, right?


---

[qiuchenjian-2]

Github user mohammadshahidkhan commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1783#discussion_r161366299
 
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/strategy/StreamingTableStrategy.scala ---
    @@ -59,7 +59,8 @@ private[sql] class StreamingTableStrategy(sparkSession: SparkSession) extends Sp
               new TableIdentifier(model.tableName, model.databaseName),
               "Alter table change datatype")
             Nil
    -      case AlterTableRenameCommand(oldTableIdentifier, _, _) =>
    +      case AlterTableRenameCommand(
    +      oldTableIdentifier, _, _) if (isCarbonStreamingTable(oldTableIdentifier)) =>
    --- End diff --
   
    @jackylk
    As per my understanding @QiangCai wanted to block the **alter table and IUD** commands for the streaming table.
    The method rejectIfStreamingTable throws exception if called over the non carbon table. Therefore the alter table and IUD commands  are blocked for non carbon table.
    So whether table is carbon table  should be checked first before checking the table is streaming or not.
    @kushalsaha The handling is needed for the commands getting rejectected here for the
    streaming table. As per my understanding instead of adding additional if check, the rejectIfStreamingTable  method could be modified the avoid blocking the alter and IUD commands for non carbon table.



---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1783#discussion_r161366727
 
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/strategy/StreamingTableStrategy.scala ---
    @@ -59,7 +59,8 @@ private[sql] class StreamingTableStrategy(sparkSession: SparkSession) extends Sp
               new TableIdentifier(model.tableName, model.databaseName),
               "Alter table change datatype")
             Nil
    -      case AlterTableRenameCommand(oldTableIdentifier, _, _) =>
    +      case AlterTableRenameCommand(
    +      oldTableIdentifier, _, _) if (isCarbonStreamingTable(oldTableIdentifier)) =>
    --- End diff --
   
    ok, I think it is better to modify `rejectIfStreamingTable` to check only carbon table


---

[qiuchenjian-2]

Github user kushalsaha commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1783#discussion_r161439942
 
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/strategy/StreamingTableStrategy.scala ---
    @@ -59,7 +59,8 @@ private[sql] class StreamingTableStrategy(sparkSession: SparkSession) extends Sp
               new TableIdentifier(model.tableName, model.databaseName),
               "Alter table change datatype")
             Nil
    -      case AlterTableRenameCommand(oldTableIdentifier, _, _) =>
    +      case AlterTableRenameCommand(
    +      oldTableIdentifier, _, _) if (isCarbonStreamingTable(oldTableIdentifier)) =>
    --- End diff --
   
    rejectIfStreamingTable method modified and validation check added if its  carbon Streaming Table then alter rename execution should fail and for all other cases alter rename query should execute.


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1783
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2785/



---