[GitHub] carbondata pull request #1791: [CARBONDATA-2010] Block streaming on main tab...

[qiuchenjian-2]

GitHub user QiangCai opened a pull request:

    https://github.com/apache/carbondata/pull/1791

    [CARBONDATA-2010] Block streaming on main table of preaggregate datamap

    If the table has 'preaggregate' DataMap, it doesn't support streaming now
   
     - [x] Any interfaces changed?
       no
     - [x] Any backward compatibility impacted?
       no
     - [x] Document update required?
       yes, i will add this limitation into
     - [x] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
              added new ut
            - How it is tested? Please attach test report.
               CI run ut
            - Is it a performance related change? Please attach the performance test report.
               no
            - Any additional information to help reviewers in testing this change.
               added code comment
           
     - [x] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
      small changes


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/QiangCai/carbondata agg_block_streaming

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1791.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1791
   
----
commit 6ccd1a060351ed7cbe1bc653623210c7e7e234f5
Author: QiangCai <qiangcai@...>
Date:   2018-01-11T07:04:22Z

    block streaming on main table of preaggregate datamap

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1791
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2695/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1791
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1462/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1791
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2832/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1791
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2714/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1791
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1481/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1791
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2841/



---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1791#discussion_r161243667
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/schema/table/TableInfo.java ---
    @@ -316,4 +316,18 @@ public static TableInfo deserialize(byte[] bytes) throws IOException {
         return parentRelationIdentifiers;
       }
     
    +  /**
    +   * whether this table has aggregation DataMap or not
    +   */
    +  public boolean hasAggregationDataMap() {
    --- End diff --
   
    I think it is ok you move this logic to CarbonTable.hasAggregationDataMap directly. We better keep TableInfo unmodified


---

[qiuchenjian-2]

Github user QiangCai commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1791#discussion_r161369358
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/schema/table/TableInfo.java ---
    @@ -316,4 +316,18 @@ public static TableInfo deserialize(byte[] bytes) throws IOException {
         return parentRelationIdentifiers;
       }
     
    +  /**
    +   * whether this table has aggregation DataMap or not
    +   */
    +  public boolean hasAggregationDataMap() {
    --- End diff --
   
    ok


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1791
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1514/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1791
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2746/



---

[qiuchenjian-2]

Github user QiangCai commented on the issue:

    https://github.com/apache/carbondata/pull/1791
 
    retest sdv please


---

[qiuchenjian-2]

Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/1791
 
    retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1791
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2774/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1791
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1541/



---

[qiuchenjian-2]

Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/1791
 
    LGTM


---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/1791


---