[GitHub] carbondata pull request #1801: [HOTFIX] [CARBONDATA-2027] Fix the Failing Co...

[qiuchenjian-2]

GitHub user anubhav100 opened a pull request:

    https://github.com/apache/carbondata/pull/1801

    [HOTFIX] [CARBONDATA-2027] Fix the Failing Concurrent Test cases for Ci

    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
   
     - [ ] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/anubhav100/incubator-carbondata CARBONDATA-2027

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1801.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1801
   
----
commit 3480f4e50d7bac64dcfac747259e53399652a083
Author: anubhav100 <anubhav.tarar@...>
Date:   2018-01-15T07:06:58Z

    Fix the Randomly failing Concurrent Test Cases For Ci

commit c2b89aca9bfd7849b124c3cc12a93b5fd04c2628
Author: anubhav100 <anubhav.tarar@...>
Date:   2018-01-15T07:08:56Z

    Fix the Randomly failing Concurrent Test Cases For Ci

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1801
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2784/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1801
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1551/



---

[qiuchenjian-2]

Github user anubhav100 commented on the issue:

    https://github.com/apache/carbondata/pull/1801
 
    retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1801
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2788/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1801
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1557/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1801
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2792/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1801
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2888/



---

[qiuchenjian-2]

Github user anubhav100 commented on the issue:

    https://github.com/apache/carbondata/pull/1801
 
    @jackylk  please review i have corrected the data rentention test cases and club the TestInsertUpdateConcurrentTest and TestInsertOverwriteAndCompaction test case but even after taking the future out  in all test cases,test cases of TestInsertUpdateConcurrentTest is failing randomly only in ci not on local may be because any one of the two threads one which is running update and other one which is executing insert overwrite get executed first which is not correct scenario insert overwrite must get executed first. please suggest?


---

[qiuchenjian-2]

Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/1801
 
    I agree with you. With taking the future, the chance is lower, but still there. Let me merge this PR first, if random failure still exist, we need to find a way to control the order of command execution


---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/1801


---