Apache CarbonData Dev Mailing List archive › Apache CarbonData JIRA issues

[GitHub] carbondata pull request #1804: [CARBONDATA-2028] Select Query failed with pr...

Classic

List

Threaded

13 messages Options

qiuchenjian-2

[GitHub] carbondata pull request #1804: [CARBONDATA-2028] Select Query failed with pr...

GitHub user BJangir opened a pull request:

https://github.com/apache/carbondata/pull/1804

[CARBONDATA-2028] Select Query failed with preagg having timeseries and normal agg table together

Select Query failed with preagg having timeseries and normal agg table together
Root Cause:- hasTimeSeriesDataMap(CarbonTable carbonTable) in CarbonUtil returns result based on 1st DataMap .

Solution :- it should iterators all the DataMap and when finds timeseries datamap , then should returns the true.

Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:

- [ ] Any interfaces changed? NO

- [ ] Any backward compatibility impacted?NO

- [ ] Document update required?NO

- [ ] Testing done =Done

- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/BJangir/incubator-carbondata CARBONDATA-2028

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/carbondata/pull/1804.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1804

----
commit e2c94bf79e33dff88fb1ce373fc0284d4dbc1c6e
Author: BJangir <babulaljangir111@...>
Date: 2018-01-15T12:01:44Z

Select Query failed with preagg having timeseries and normal agg table together

----

---

qiuchenjian-2

[GitHub] carbondata pull request #1804: [CARBONDATA-2028] Select Query failed with pr...

Github user kumarvishal09 commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/1804#discussion_r161509204

--- Diff: core/src/main/java/org/apache/carbondata/core/util/CarbonUtil.java ---
@@ -2315,7 +2315,10 @@ public static boolean hasTimeSeriesDataMap(CarbonTable carbonTable) {
List<DataMapSchema> dataMapSchemaList = carbonTable.getTableInfo().getDataMapSchemaList();
for (DataMapSchema dataMapSchema : dataMapSchemaList) {
if (dataMapSchema instanceof AggregationDataMapSchema) {
- return ((AggregationDataMapSchema) dataMapSchema).isTimeseriesDataMap();
+ boolean istimeseries = ((AggregationDataMapSchema) dataMapSchema).isTimeseriesDataMap();
--- End diff --

Please do not store isTimeseriesDatamap value in any boolean add a if check and return false

---

qiuchenjian-2