[GitHub] carbondata pull request #1807: [CARBONDATA-2030]avg with Aggregate table for...

classic Classic list List threaded Threaded
19 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #1807: [CARBONDATA-2030]avg with Aggregate table for...

qiuchenjian-2
GitHub user BJangir opened a pull request:

    https://github.com/apache/carbondata/pull/1807

    [CARBONDATA-2030]avg with Aggregate table for double data type is failed.

    avg with Aggregate table for double data type is failed.
   
    Root Cause:- for avg column , agg table returns sum and count , sum col. data type is based on actual data type of the column but for count col. always  LongType .so while doing divide by it is failed in spark layer
   
    Solution :- Change the return datatype for count also . use the same datatype sum column .
   
    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [ ] Any interfaces changed?
     NA
     - [ ] Any backward compatibility impacted?
     NA
     - [ ] Document update required? NA
   
     - [ ] Testing done=Done
           Added UT.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/BJangir/incubator-carbondata CARBONDATA-2030

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1807.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1807
   
----
commit c34dbe766c8878ece0aee5d9d2de9b06bac85f96
Author: BJangir <babulaljangir111@...>
Date:   2018-01-15T17:05:54Z

    avg with Aggregate table for double data type is failed.

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1807: [CARBONDATA-2030]avg with Aggregate table for double...

qiuchenjian-2
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1807
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2900/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1807: [CARBONDATA-2030]avg with Aggregate table for double...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1807
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2809/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1807: [CARBONDATA-2030]avg with Aggregate table for double...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1807
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1573/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1807: [CARBONDATA-2030]avg with Aggregate table for double...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user kunal642 commented on the issue:

    https://github.com/apache/carbondata/pull/1807
 
    retest this please


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1807: [CARBONDATA-2030]avg with Aggregate table for double...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1807
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1579/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1807: [CARBONDATA-2030]avg with Aggregate table for double...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1807
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2814/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1807: [CARBONDATA-2030]avg with Aggregate table for double...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user BJangir commented on the issue:

    https://github.com/apache/carbondata/pull/1807
 
    retest this please


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1807: [CARBONDATA-2030]avg with Aggregate table for double...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1807
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1589/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1807: [CARBONDATA-2030]avg with Aggregate table for double...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1807
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2832/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1807: [CARBONDATA-2030]avg with Aggregate table for double...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1807
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1597/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1807: [CARBONDATA-2030]avg with Aggregate table for double...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user BJangir commented on the issue:

    https://github.com/apache/carbondata/pull/1807
 
    retest this please


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1807: [CARBONDATA-2030]avg with Aggregate table for double...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1807
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1614/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1807: [CARBONDATA-2030]avg with Aggregate table for double...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1807
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2850/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1807: [CARBONDATA-2030]avg with Aggregate table for double...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user kumarvishal09 commented on the issue:

    https://github.com/apache/carbondata/pull/1807
 
    retest sdv please


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1807: [CARBONDATA-2030]avg with Aggregate table for double...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user kumarvishal09 commented on the issue:

    https://github.com/apache/carbondata/pull/1807
 
    LGTM


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #1807: [CARBONDATA-2030]avg with Aggregate table for...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/1807


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1807: [CARBONDATA-2030]avg with Aggregate table for double...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1807
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1678/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1807: [CARBONDATA-2030]avg with Aggregate table for double...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1807
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2911/



---