[GitHub] carbondata pull request #1815: [WIP]Clean up temp folder after task completi...

[qiuchenjian-2]

GitHub user ravipesala opened a pull request:

    https://github.com/apache/carbondata/pull/1815

    [WIP]Clean up temp folder after task completion in case of partitioning

   
   
    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
   
     - [ ] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ravipesala/incubator-carbondata rename-issue

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1815.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1815
   
----
commit eccb8521f1081b73d018be7a945762eb09ca6168
Author: ravipesala <ravi.pesala@...>
Date:   2018-01-17T02:58:31Z

    Clean up temp folder after task completion

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1815
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2868/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1815
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1635/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1815
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2873/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1815
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1641/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1815
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1666/



---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1815#discussion_r162072998
 
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/datasources/CarbonFileFormat.scala ---
    @@ -202,7 +231,7 @@ private trait AbstractCarbonOutputWriter {
     
     private class CarbonOutputWriter(path: String,
         context: TaskAttemptContext,
    -    fieldTypes: Seq[DataType])
    +    fieldTypes: Seq[DataType], taskNo : String)
    --- End diff --
   
    move taskNo to next line


---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1815#discussion_r162073688
 
    --- Diff: processing/src/main/java/org/apache/carbondata/processing/store/writer/AbstractFactDataWriter.java ---
    @@ -317,8 +313,7 @@ public void initializeWriter() throws CarbonDataWriterException {
             .getCarbonDataFileName(fileCount, model.getCarbonDataFileAttributes().getTaskId(),
                 model.getBucketId(), model.getTaskExtension(),
                 "" + model.getCarbonDataFileAttributes().getFactTimeStamp());
    -    this.carbonDataFileTempPath = chosenTempLocation + File.separator
    -        + carbonDataFileName + CarbonCommonConstants.FILE_INPROGRESS_STATUS;
    +    this.carbonDataFileTempPath = chosenTempLocation + File.separator + carbonDataFileName;
    --- End diff --
   
    For the temp location, can we add a "carbon" prefix to the path name, currently it is just a nanotime number, I think it is better if user can tell which folder is created by carbon, even it is temp folder


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1815
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2900/



---

[qiuchenjian-2]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1815#discussion_r162128053
 
    --- Diff: processing/src/main/java/org/apache/carbondata/processing/store/writer/AbstractFactDataWriter.java ---
    @@ -317,8 +313,7 @@ public void initializeWriter() throws CarbonDataWriterException {
             .getCarbonDataFileName(fileCount, model.getCarbonDataFileAttributes().getTaskId(),
                 model.getBucketId(), model.getTaskExtension(),
                 "" + model.getCarbonDataFileAttributes().getFactTimeStamp());
    -    this.carbonDataFileTempPath = chosenTempLocation + File.separator
    -        + carbonDataFileName + CarbonCommonConstants.FILE_INPROGRESS_STATUS;
    +    this.carbonDataFileTempPath = chosenTempLocation + File.separator + carbonDataFileName;
    --- End diff --
   
    ok


---

[qiuchenjian-2]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1815#discussion_r162128093
 
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/datasources/CarbonFileFormat.scala ---
    @@ -202,7 +231,7 @@ private trait AbstractCarbonOutputWriter {
     
     private class CarbonOutputWriter(path: String,
         context: TaskAttemptContext,
    -    fieldTypes: Seq[DataType])
    +    fieldTypes: Seq[DataType], taskNo : String)
    --- End diff --
   
    ok


---

[qiuchenjian-2]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1815#discussion_r162129482
 
    --- Diff: processing/src/main/java/org/apache/carbondata/processing/store/writer/AbstractFactDataWriter.java ---
    @@ -317,8 +313,7 @@ public void initializeWriter() throws CarbonDataWriterException {
             .getCarbonDataFileName(fileCount, model.getCarbonDataFileAttributes().getTaskId(),
                 model.getBucketId(), model.getTaskExtension(),
                 "" + model.getCarbonDataFileAttributes().getFactTimeStamp());
    -    this.carbonDataFileTempPath = chosenTempLocation + File.separator
    -        + carbonDataFileName + CarbonCommonConstants.FILE_INPROGRESS_STATUS;
    +    this.carbonDataFileTempPath = chosenTempLocation + File.separator + carbonDataFileName;
    --- End diff --
   
    ok


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1815
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1687/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1815
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2920/



---

[qiuchenjian-2]

Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/1815
 
    It seems there are two testcase failure. And please change PR title


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1815
 
    retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1815
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1695/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1815
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2928/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1815
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2947/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1815
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1699/



---