[GitHub] carbondata pull request #1828: [CARBONDATA-2049] CarbonCleanFilesCommand tab...

[qiuchenjian-2]

GitHub user mohammadshahidkhan opened a pull request:

    https://github.com/apache/carbondata/pull/1828

    [CARBONDATA-2049] CarbonCleanFilesCommand table path problem

    **Problem:**
    In CarbonCleanFilesCommand datbaseLocation is being passed instead of the tablePath in case of forceclean.
    And in case of cleanGarbageData, storeLocation is being passed instead of the tablePath.
   
   
     - [X] Any interfaces changed?
     None
     - [X] Any backward compatibility impacted?
     None
     - [X] Document update required?
    None
     - [X] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
        Corrected test case
     - [X] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
    NA


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mohammadshahidkhan/incubator-carbondata cleancommand_fix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1828.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1828
   
----
commit 8bfeb75b9af0de7d02f94a593c283d6d99df6f92
Author: mohammadshahidkhan <mohdshahidkhan1987@...>
Date:   2018-01-16T06:19:54Z

    [CARBONDATA-2049] CarbonCleanFilesCommand table path problem

----


---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1828#discussion_r162302249
 
    --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/api/CarbonStore.scala ---
    @@ -98,34 +98,44 @@ object CarbonStore {
         }
       }
     
    +  /**
    +   *
    --- End diff --
   
    please complete the description


---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1828#discussion_r162302554
 
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonCleanFilesCommand.scala ---
    @@ -70,11 +70,12 @@ case class CarbonCleanFilesCommand(
           databaseNameOp: Option[String], tableName: String): Unit = {
         val dbName = CarbonEnv.getDatabaseName(databaseNameOp)(sparkSession)
         val databaseLocation = CarbonEnv.getDatabaseLocation(dbName, sparkSession)
    +    val tablePath = databaseLocation + CarbonCommonConstants.FILE_SEPARATOR + tableName
         CarbonStore.cleanFiles(
           dbName,
           tableName,
    -      databaseLocation,
    -      null,
    +      tablePath,
    +      null, // in case of delete all data carbonTable is not required.
    --- End diff --
   
    can you add parameter name also to make it more readable


---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1828#discussion_r162302717
 
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/util/CleanFiles.scala ---
    @@ -33,15 +33,19 @@ object CleanFiles {
        * @param spark
        * @param dbName
        * @param tableName
    --- End diff --
   
    please complete the description


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1828
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1707/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1828
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2942/



---

[qiuchenjian-2]

Github user mohammadshahidkhan commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1828#discussion_r162357211
 
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonCleanFilesCommand.scala ---
    @@ -70,11 +70,12 @@ case class CarbonCleanFilesCommand(
           databaseNameOp: Option[String], tableName: String): Unit = {
         val dbName = CarbonEnv.getDatabaseName(databaseNameOp)(sparkSession)
         val databaseLocation = CarbonEnv.getDatabaseLocation(dbName, sparkSession)
    +    val tablePath = databaseLocation + CarbonCommonConstants.FILE_SEPARATOR + tableName
         CarbonStore.cleanFiles(
           dbName,
           tableName,
    -      databaseLocation,
    -      null,
    +      tablePath,
    +      null, // in case of delete all data carbonTable is not required.
    --- End diff --
   
    added parameter for readability


---

[qiuchenjian-2]

Github user mohammadshahidkhan commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1828#discussion_r162357297
 
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/util/CleanFiles.scala ---
    @@ -33,15 +33,19 @@ object CleanFiles {
        * @param spark
        * @param dbName
        * @param tableName
    --- End diff --
   
    Added descriptions


---

[qiuchenjian-2]

Github user mohammadshahidkhan commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1828#discussion_r162357455
 
    --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/api/CarbonStore.scala ---
    @@ -98,34 +98,44 @@ object CarbonStore {
         }
       }
     
    +  /**
    +   *
    --- End diff --
   
    Please check added descriptions


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1828
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2961/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1828
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1734/



---

[qiuchenjian-2]

Github user mohammadshahidkhan commented on the issue:

    https://github.com/apache/carbondata/pull/1828
 
    retest sdv please


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1828
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3038/



---

[qiuchenjian-2]

Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/1828
 
    LGTM


---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/1828


---