[GitHub] carbondata pull request #1831: [[CARBONDATA-1993] Carbon properties default ...

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1831
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3334/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1831
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3337/



---

[qiuchenjian-2]

Github user KanakaKumar commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1831#discussion_r165809183
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java ---
    @@ -1264,18 +1231,7 @@
       /**
        * default property of unsafe processing
        */
    -  public static final String ENABLE_UNSAFE_IN_QUERY_EXECUTION_DEFAULTVALUE = "false";
    -
    -  /**
    -   * property for offheap based processing
    -   */
    -  @CarbonProperty
    -  public static final String USE_OFFHEAP_IN_QUERY_PROCSSING = "use.offheap.in.query.processing";
    -
    -  /**
    -   * default value of offheap based processing
    -   */
    -  public static final String USE_OFFHEAP_IN_QUERY_PROCSSING_DEFAULT = "true";
    +  public static final String ENABLE_UNSAFE_IN_QUERY_EXECUTION_DEFAULTVALUE = "true";
    --- End diff --
   
    Please make ENABLE_UNSAFE_COLUMN_PAGE_LOADING = "enable.unsafe.columnpage" also "true" by default as its the common configuration for query also.


---

[qiuchenjian-2]

Github user mohammadshahidkhan commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1831#discussion_r165810447
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java ---
    @@ -1264,18 +1231,7 @@
       /**
        * default property of unsafe processing
        */
    -  public static final String ENABLE_UNSAFE_IN_QUERY_EXECUTION_DEFAULTVALUE = "false";
    -
    -  /**
    -   * property for offheap based processing
    -   */
    -  @CarbonProperty
    -  public static final String USE_OFFHEAP_IN_QUERY_PROCSSING = "use.offheap.in.query.processing";
    -
    -  /**
    -   * default value of offheap based processing
    -   */
    -  public static final String USE_OFFHEAP_IN_QUERY_PROCSSING_DEFAULT = "true";
    +  public static final String ENABLE_UNSAFE_IN_QUERY_EXECUTION_DEFAULTVALUE = "true";
    --- End diff --
   
    Change default  value for "enable.unsafe.columnpage"  to true


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1831
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2248/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1831
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3492/



---

[qiuchenjian-2]

Github user mohammadshahidkhan commented on the issue:

    https://github.com/apache/carbondata/pull/1831
 
    retest this please


---

[qiuchenjian-2]

Github user KanakaKumar commented on the issue:

    https://github.com/apache/carbondata/pull/1831
 
    retest sdv please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1831
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3503/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1831
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2265/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1831
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3353/



---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/1831


---