[GitHub] carbondata pull request #1837: [WIP] Refactored code segregated process meta...

[qiuchenjian-2]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1837#discussion_r163760950
 
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/hive/CarbonRelation.scala ---
    @@ -215,8 +214,19 @@ case class CarbonRelation(
               carbonTable.getCarbonTableIdentifier).getPath
             val fileType = FileFactory.getFileType(tablePath)
             if (FileFactory.isFileExist(tablePath, fileType)) {
    +          // get the valid segments
    +          val segments = new SegmentStatusManager(carbonTable.getAbsoluteTableIdentifier)
    +            .getValidAndInvalidSegments.getValidSegments.asScala
    +          var size = 0L
    +          // for each segment calculate the size
    +          segments.foreach {validSeg =>
    +            size = size +
    +                   FileFactory.getDirectorySize(CarbonTablePath.getSegmentPath(tablePath, validSeg))
    --- End diff --
   
    Please format as below
    ```
     size = size + FileFactory.getDirectorySize(
                  CarbonTablePath.getSegmentPath(tablePath, validSeg))
    ```


---

[qiuchenjian-2]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1837#discussion_r163761030
 
    --- Diff: processing/src/main/java/org/apache/carbondata/processing/loading/events/LoadEvents.java ---
    @@ -128,6 +129,20 @@ public CarbonTableIdentifier getCarbonTableIdentifier() {
         }
       }
     
    +  public static class LoadMetadataEvent extends Event {
    --- End diff --
   
    Please add comment


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1837
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3111/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1837
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1879/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1837
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3113/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1837
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1881/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1837
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3090/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1837
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1884/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1837
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3116/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1837
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3092/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1837
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3120/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1837
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1888/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1837
 
    LGTM


---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/1837


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1837
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3093/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1837
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3095/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1837
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3099/



---