[GitHub] carbondata pull request #1859: [CARBONDATA-2077][CARBONDATA-1516] it should ...

classic Classic list List threaded Threaded
10 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #1859: [CARBONDATA-2077][CARBONDATA-1516] it should ...

qiuchenjian-2
GitHub user xubo245 opened a pull request:

    https://github.com/apache/carbondata/pull/1859

    [CARBONDATA-2077][CARBONDATA-1516] it should throw no such datamap when drop datamap and the datamap does not exist

   
    DROP DATAMAP should throw exception if table not exist, even though there is IF EXISTS
   
    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [ ] Any interfaces changed?
     No
     - [ ] Any backward compatibility impacted?
     NO
     - [ ] Document update required?
    NO
     - [ ] Testing done
    add test case in TestTimeSeriesDropSuite
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
    No


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/xubo245/carbondata CARBONDATA2075_dropDatamapExceptionWhenNoSuchTableIFExist

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1859.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1859
   
----
commit 76b2c0363e57fc27a5a4754c8a97ee39ec1adf95
Author: xubo245 <601450868@...>
Date:   2018-01-25T08:42:13Z

    [CARBONDATA-2077][CARBONDATA-1516] it should throw no such datamap when drop datamap and the datamap does not exist
   
    DROP DATAMAP should throw exception if table not exist, even though there is IF EXISTS

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1859: [CARBONDATA-2077][CARBONDATA-1516] it should throw n...

qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1859
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1883/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1859: [CARBONDATA-2077][CARBONDATA-1516] it should throw n...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1859
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3115/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1859: [CARBONDATA-2077][CARBONDATA-1516] it should throw n...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1859
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3094/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1859: [CARBONDATA-2077][CARBONDATA-1516] it should throw n...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1859
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3131/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1859: [CARBONDATA-2077][CARBONDATA-1516] it should throw n...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1859
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1898/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1859: [CARBONDATA-2077][CARBONDATA-1516] it should throw n...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1859
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3108/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1859: [CARBONDATA-2077][CARBONDATA-1516] it should throw n...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user xubo245 commented on the issue:

    https://github.com/apache/carbondata/pull/1859
 
    Please review it @jackylk @kumarvishal09


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1859: [CARBONDATA-2077][CARBONDATA-1516] it should throw n...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user xubo245 commented on the issue:

    https://github.com/apache/carbondata/pull/1859
 
    it's combined to https://github.com/apache/carbondata/pull/1858


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #1859: [CARBONDATA-2077][CARBONDATA-1516] it should ...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user xubo245 closed the pull request at:

    https://github.com/apache/carbondata/pull/1859


---