[GitHub] carbondata pull request #1861: [CARBONDATA-2078][CARBONDATA-1516] Add 'if no...

[qiuchenjian-2]

Github user xubo245 commented on the issue:

    https://github.com/apache/carbondata/pull/1861
 
    @kumarvishal09 done, please review https://github.com/apache/carbondata/pull/1861/commits/6537d1606282db8418ac580ce476c7ea8a856a0c


---

[qiuchenjian-2]

Github user xubo245 commented on the issue:

    https://github.com/apache/carbondata/pull/1861
 
    Retest this please


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1861
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3230/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1861
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2064/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1861
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3301/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1861
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3306/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1861
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2069/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1861
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3239/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1861
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3333/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1861
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2097/



---

[qiuchenjian-2]

Github user kumarvishal09 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1861#discussion_r165040234
 
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/datamap/CarbonCreateDataMapCommand.scala ---
    @@ -49,10 +61,21 @@ case class CarbonCreateDataMapCommand(
           throw new MalformedCarbonCommandException("Streaming table does not support creating datamap")
         }
         val LOGGER = LogServiceFactory.getLogService(this.getClass.getCanonicalName)
    +    val dbName = tableIdentifier.database.getOrElse("default")
    +    val tableName = tableIdentifier.table + "_" + dataMapName
     
    -    if (dmClassName.equalsIgnoreCase(PREAGGREGATE.toString) ||
    +    if (tableExists(sparkSession, dbName, tableName)) {
    --- End diff --
   
    tableExists method is called only from processMeta, so better not to create any method you can update the if statement
    if(sparkSession.sessionState.catalog.listTables(dbName) .exists(_.table.equalsIgnoreCase(tableName)))



---

[qiuchenjian-2]

Github user xubo245 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1861#discussion_r165046584
 
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/datamap/CarbonCreateDataMapCommand.scala ---
    @@ -49,10 +61,21 @@ case class CarbonCreateDataMapCommand(
           throw new MalformedCarbonCommandException("Streaming table does not support creating datamap")
         }
         val LOGGER = LogServiceFactory.getLogService(this.getClass.getCanonicalName)
    +    val dbName = tableIdentifier.database.getOrElse("default")
    +    val tableName = tableIdentifier.table + "_" + dataMapName
     
    -    if (dmClassName.equalsIgnoreCase(PREAGGREGATE.toString) ||
    +    if (tableExists(sparkSession, dbName, tableName)) {
    --- End diff --
   
    ok,done


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1861
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3345/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1861
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2109/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1861
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3257/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1861
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3270/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1861
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3382/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1861
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2145/



---

[qiuchenjian-2]

Github user xubo245 commented on the issue:

    https://github.com/apache/carbondata/pull/1861
 
    CI pass @kumarvishal09


---

[qiuchenjian-2]

Github user kunal642 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1861#discussion_r165270563
 
    --- Diff: integration/spark-common-test/src/test/scala/org/apache/carbondata/integration/spark/testsuite/timeseries/TestTimeSeriesCreateTable.scala ---
    @@ -81,29 +82,29 @@ class TestTimeSeriesCreateTable extends QueryTest with BeforeAndAfterAll {
            """.stripMargin)
       }
     
    -  test("test timeseries create table Zero") {
    +  test("test timeseries create table 1") {
    --- End diff --
   
    Please remove unnecessary changes like this


---