[GitHub] carbondata pull request #1865: [CARBONDATA-2088][CARBONDATA-1516] It better ...

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1865
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3193/



---

[qiuchenjian-2]

Github user xubo245 commented on the issue:

    https://github.com/apache/carbondata/pull/1865
 
    retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1865
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3240/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1865
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2006/



---

[qiuchenjian-2]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1865#discussion_r164652496
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/schema/table/DataMapClassName.java ---
    @@ -0,0 +1,52 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.carbondata.core.metadata.schema.table;
    +
    +/**
    + * type for create datamap
    + * The syntax of datamap creation is as follows.
    + * CREATE DATAMAP IF NOT EXISTS dataMapName ON TABLE tableName USING 'DataMapClassName'
    + * DMPROPERTIES('KEY'='VALUE') AS SELECT COUNT(COL1) FROM tableName
    + *
    + * Please refer {{org.apache.spark.sql.parser.CarbonSpark2SqlParser}}
    + */
    +
    +public enum DataMapClassName {
    --- End diff --
   
    If you mention name as `DataMapClassName` name then you should have class names also as part of Enum. Like
    ```
    DataMapClassName(int value, String shortName,  String className)
    ```


---

[qiuchenjian-2]

Github user xubo245 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1865#discussion_r164654217
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/schema/table/DataMapClassName.java ---
    @@ -0,0 +1,52 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.carbondata.core.metadata.schema.table;
    +
    +/**
    + * type for create datamap
    + * The syntax of datamap creation is as follows.
    + * CREATE DATAMAP IF NOT EXISTS dataMapName ON TABLE tableName USING 'DataMapClassName'
    + * DMPROPERTIES('KEY'='VALUE') AS SELECT COUNT(COL1) FROM tableName
    + *
    + * Please refer {{org.apache.spark.sql.parser.CarbonSpark2SqlParser}}
    + */
    +
    +public enum DataMapClassName {
    --- End diff --
   
    But now we don't support className. How about change DataMapClassName to DataMapName?


---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1865#discussion_r164655685
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/schema/table/DataMapClassName.java ---
    @@ -0,0 +1,52 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.carbondata.core.metadata.schema.table;
    +
    +/**
    + * type for create datamap
    + * The syntax of datamap creation is as follows.
    + * CREATE DATAMAP IF NOT EXISTS dataMapName ON TABLE tableName USING 'DataMapClassName'
    + * DMPROPERTIES('KEY'='VALUE') AS SELECT COUNT(COL1) FROM tableName
    + *
    + * Please refer {{org.apache.spark.sql.parser.CarbonSpark2SqlParser}}
    + */
    +
    +public enum DataMapClassName {
    +  PREAGGREGATE((short) 1, "preaggregate"),
    +  TIMESERIES((short) 2, "timeseries");
    +  private int value;
    --- End diff --
   
    You do not need this int value


---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1865#discussion_r164656315
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/schema/table/Granularity.java ---
    @@ -0,0 +1,62 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.carbondata.core.metadata.schema.table;
    --- End diff --
   
    Move it to time series package


---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1865#discussion_r164656340
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/schema/table/Granularity.java ---
    @@ -0,0 +1,62 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.carbondata.core.metadata.schema.table;
    +
    +/**
    + * type for create datamap
    + * The syntax of datamap creation is as follows.
    + * CREATE DATAMAP IF NOT EXISTS dataMapName ON TABLE tableName USING 'DataMapClassName'
    + * DMPROPERTIES('KEY'='VALUE') AS SELECT COUNT(COL1) FROM tableName
    + *
    + * Please refer {{org.apache.spark.sql.parser.CarbonSpark2SqlParser}}
    + */
    +
    +public enum Granularity {
    +  YEAR((short) 1, "year_granularity", "year"),
    +  MONTH((short) 2, "month_granularity", "month"),
    +  DAY((short) 3, "day_granularity", "day"),
    +  HOUR((short) 4, "hour_granularity", "hour"),
    +  MINUTE((short) 5, "minute_granularity", "minute"),
    +  SECOND((short) 6, "second_granularity", "second");
    +  private int value;
    --- End diff --
   
    int is not required


---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1865#discussion_r164656476
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/schema/table/Granularity.java ---
    @@ -0,0 +1,62 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.carbondata.core.metadata.schema.table;
    +
    +/**
    + * type for create datamap
    + * The syntax of datamap creation is as follows.
    + * CREATE DATAMAP IF NOT EXISTS dataMapName ON TABLE tableName USING 'DataMapClassName'
    + * DMPROPERTIES('KEY'='VALUE') AS SELECT COUNT(COL1) FROM tableName
    + *
    + * Please refer {{org.apache.spark.sql.parser.CarbonSpark2SqlParser}}
    + */
    +
    +public enum Granularity {
    +  YEAR((short) 1, "year_granularity", "year"),
    +  MONTH((short) 2, "month_granularity", "month"),
    +  DAY((short) 3, "day_granularity", "day"),
    +  HOUR((short) 4, "hour_granularity", "hour"),
    +  MINUTE((short) 5, "minute_granularity", "minute"),
    +  SECOND((short) 6, "second_granularity", "second");
    +  private int value;
    +  private String name;
    +  private String time;
    --- End diff --
   
    This is not required


---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1865#discussion_r164656572
 
    --- Diff: integration/spark-common/src/main/java/org/apache/carbondata/spark/exception/CarbonIllegalArgumentException.java ---
    @@ -0,0 +1,32 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.carbondata.spark.exception;
    +
    +/**
    + * Throw exception when using illegal argument
    + */
    +public class CarbonIllegalArgumentException extends MalformedCarbonCommandException {
    --- End diff --
   
    Make it specific: UnsupportedDataMapException


---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1865#discussion_r164656822
 
    --- Diff: integration/spark-common/src/main/java/org/apache/carbondata/spark/exception/UnsupportedDataMapException.java ---
    @@ -0,0 +1,32 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.carbondata.spark.exception;
    +
    +/**
    + * Throw exception when using unsupported datamap type
    + */
    +public class UnsupportedDataMapException extends MalformedCarbonCommandException {
    --- End diff --
   
    Rename to `MalformedDataMapCommandException`


---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1865#discussion_r164657031
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java ---
    @@ -1525,9 +1525,7 @@
        */
       public static final long HANDOFF_SIZE_DEFAULT = 1024L * 1024 * 1024;
     
    -  public static final String TIMESERIES_EVENTTIME = "timeseries.eventtime";
    -
    -  public static final String TIMESERIES_HIERARCHY = "timeseries.hierarchy";
    +  public static final String TIMESERIES_EVENTTIME = "event_time";
    --- End diff --
   
    Declare the constant in datamap class, not in CarbonCommonConstaints


---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1865#discussion_r164658274
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/schema/table/DataMapClassName.java ---
    @@ -0,0 +1,52 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.carbondata.core.metadata.schema.table;
    +
    +/**
    + * type for create datamap
    + * The syntax of datamap creation is as follows.
    + * CREATE DATAMAP IF NOT EXISTS dataMapName ON TABLE tableName USING 'DataMapClassName'
    + * DMPROPERTIES('KEY'='VALUE') AS SELECT COUNT(COL1) FROM tableName
    + *
    + * Please refer {{org.apache.spark.sql.parser.CarbonSpark2SqlParser}}
    + */
    +
    +public enum DataMapClassName {
    --- End diff --
   
    I suggest `DataMapProvider`


---

[qiuchenjian-2]

Github user xubo245 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1865#discussion_r164663023
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/schema/table/DataMapClassName.java ---
    @@ -0,0 +1,52 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.carbondata.core.metadata.schema.table;
    +
    +/**
    + * type for create datamap
    + * The syntax of datamap creation is as follows.
    + * CREATE DATAMAP IF NOT EXISTS dataMapName ON TABLE tableName USING 'DataMapClassName'
    + * DMPROPERTIES('KEY'='VALUE') AS SELECT COUNT(COL1) FROM tableName
    + *
    + * Please refer {{org.apache.spark.sql.parser.CarbonSpark2SqlParser}}
    + */
    +
    +public enum DataMapClassName {
    +  PREAGGREGATE((short) 1, "preaggregate"),
    +  TIMESERIES((short) 2, "timeseries");
    +  private int value;
    --- End diff --
   
    ok, done


---

[qiuchenjian-2]

Github user xubo245 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1865#discussion_r164665269
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/schema/table/Granularity.java ---
    @@ -0,0 +1,62 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.carbondata.core.metadata.schema.table;
    --- End diff --
   
    ok, create datamap package in schema package  and move it


---

[qiuchenjian-2]

Github user xubo245 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1865#discussion_r164665299
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/schema/table/Granularity.java ---
    @@ -0,0 +1,62 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.carbondata.core.metadata.schema.table;
    +
    +/**
    + * type for create datamap
    + * The syntax of datamap creation is as follows.
    + * CREATE DATAMAP IF NOT EXISTS dataMapName ON TABLE tableName USING 'DataMapClassName'
    + * DMPROPERTIES('KEY'='VALUE') AS SELECT COUNT(COL1) FROM tableName
    + *
    + * Please refer {{org.apache.spark.sql.parser.CarbonSpark2SqlParser}}
    + */
    +
    +public enum Granularity {
    +  YEAR((short) 1, "year_granularity", "year"),
    +  MONTH((short) 2, "month_granularity", "month"),
    +  DAY((short) 3, "day_granularity", "day"),
    +  HOUR((short) 4, "hour_granularity", "hour"),
    +  MINUTE((short) 5, "minute_granularity", "minute"),
    +  SECOND((short) 6, "second_granularity", "second");
    +  private int value;
    --- End diff --
   
    ok, done


---

[qiuchenjian-2]

Github user xubo245 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1865#discussion_r164665828
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/schema/table/Granularity.java ---
    @@ -0,0 +1,62 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.carbondata.core.metadata.schema.table;
    +
    +/**
    + * type for create datamap
    + * The syntax of datamap creation is as follows.
    + * CREATE DATAMAP IF NOT EXISTS dataMapName ON TABLE tableName USING 'DataMapClassName'
    + * DMPROPERTIES('KEY'='VALUE') AS SELECT COUNT(COL1) FROM tableName
    + *
    + * Please refer {{org.apache.spark.sql.parser.CarbonSpark2SqlParser}}
    + */
    +
    +public enum Granularity {
    +  YEAR((short) 1, "year_granularity", "year"),
    +  MONTH((short) 2, "month_granularity", "month"),
    +  DAY((short) 3, "day_granularity", "day"),
    +  HOUR((short) 4, "hour_granularity", "hour"),
    +  MINUTE((short) 5, "minute_granularity", "minute"),
    +  SECOND((short) 6, "second_granularity", "second");
    +  private int value;
    +  private String name;
    +  private String time;
    --- End diff --
   
    ok,done


---

[qiuchenjian-2]

Github user xubo245 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1865#discussion_r164667994
 
    --- Diff: integration/spark-common/src/main/java/org/apache/carbondata/spark/exception/CarbonIllegalArgumentException.java ---
    @@ -0,0 +1,32 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.carbondata.spark.exception;
    +
    +/**
    + * Throw exception when using illegal argument
    + */
    +public class CarbonIllegalArgumentException extends MalformedCarbonCommandException {
    --- End diff --
   
    ok, done


---

[qiuchenjian-2]

Github user xubo245 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1865#discussion_r164668021
 
    --- Diff: integration/spark-common/src/main/java/org/apache/carbondata/spark/exception/UnsupportedDataMapException.java ---
    @@ -0,0 +1,32 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.carbondata.spark.exception;
    +
    +/**
    + * Throw exception when using unsupported datamap type
    + */
    +public class UnsupportedDataMapException extends MalformedCarbonCommandException {
    --- End diff --
   
    ok, done


---