[GitHub] carbondata pull request #1867: [CARBONDATA-2055]Support integrating Stream t...

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1867
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3155/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1867
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1957/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1867
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3191/



---

[qiuchenjian-2]

Github user zzcclp commented on the issue:

    https://github.com/apache/carbondata/pull/1867
 
    retest sdv please


---

[qiuchenjian-2]

Github user zzcclp commented on the issue:

    https://github.com/apache/carbondata/pull/1867
 
    retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1867
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1959/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1867
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3193/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1867
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3157/



---

[qiuchenjian-2]

Github user zzcclp commented on the issue:

    https://github.com/apache/carbondata/pull/1867
 
    retest sdv please


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1867
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3160/



---

[qiuchenjian-2]

Github user QiangCai commented on the issue:

    https://github.com/apache/carbondata/pull/1867
 
    LGTM


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1867
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1983/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1867
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3218/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1867
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3178/



---

[qiuchenjian-2]

Github user zzcclp commented on the issue:

    https://github.com/apache/carbondata/pull/1867
 
    retest sdv please.


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1867
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3191/



---

[qiuchenjian-2]

Github user chenliang613 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1867#discussion_r164651907
 
    --- Diff: examples/spark2/src/main/scala/org/apache/carbondata/examples/CarbonStreamSparkStreamingExample.scala ---
    @@ -0,0 +1,245 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.carbondata.examples
    +
    +import java.io.{File, PrintWriter}
    +import java.net.ServerSocket
    +
    +import org.apache.hadoop.conf.Configuration
    +import org.apache.spark.rdd.RDD
    +import org.apache.spark.sql.CarbonEnv
    +import org.apache.spark.sql.CarbonStreamSparkStreamFactory
    +import org.apache.spark.sql.catalyst.InternalRow
    +import org.apache.spark.sql.SaveMode
    +import org.apache.spark.sql.SparkSession
    +import org.apache.spark.streaming.{Seconds, StreamingContext, Time}
    +
    +import org.apache.carbondata.core.constants.CarbonCommonConstants
    +import org.apache.carbondata.core.util.CarbonProperties
    +import org.apache.carbondata.core.util.path.{CarbonStorePath, CarbonTablePath}
    +import org.apache.carbondata.streaming.CarbonSparkStreamingListener
    +import org.apache.carbondata.streaming.parser.CarbonStreamParser
    +
    +/**
    + * This example introduces how to use Spark Streaming to write data
    + * to CarbonData stream table.
    + */
    +// scalastyle:off println
    +
    +case class StreamData(id: Int, name: String, city: String, salary: Float)
    --- End diff --
   
    Can you explain , what are the difference of "CarbonStreamSparkStreamingExample.scala" and "CarbonBatchSparkStreamingExample", whether can merge the two examples into one , or not ?


---

[qiuchenjian-2]

Github user chenliang613 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1867#discussion_r164652953
 
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/CarbonStreamSparkStreamFactory.scala ---
    @@ -0,0 +1,58 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.sql
    +
    +import org.apache.commons.lang3.StringUtils
    +
    +import org.apache.carbondata.streaming.CarbonStreamException
    +import org.apache.carbondata.streaming.CarbonStreamSparkStreaming
    +import org.apache.carbondata.streaming.CarbonStreamSparkStreamingWriter
    +
    +/**
    + * Create CarbonStreamSparkStreamingWriter for stream table
    + * when integrate with Spark Streaming
    + */
    +object CarbonStreamSparkStreamFactory {
    --- End diff --
   
    How about using "CarbonSparkStreamingFactory" as name?


---

[qiuchenjian-2]

Github user zzcclp commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1867#discussion_r164689949
 
    --- Diff: examples/spark2/src/main/scala/org/apache/carbondata/examples/CarbonStreamSparkStreamingExample.scala ---
    @@ -0,0 +1,245 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.carbondata.examples
    +
    +import java.io.{File, PrintWriter}
    +import java.net.ServerSocket
    +
    +import org.apache.hadoop.conf.Configuration
    +import org.apache.spark.rdd.RDD
    +import org.apache.spark.sql.CarbonEnv
    +import org.apache.spark.sql.CarbonStreamSparkStreamFactory
    +import org.apache.spark.sql.catalyst.InternalRow
    +import org.apache.spark.sql.SaveMode
    +import org.apache.spark.sql.SparkSession
    +import org.apache.spark.streaming.{Seconds, StreamingContext, Time}
    +
    +import org.apache.carbondata.core.constants.CarbonCommonConstants
    +import org.apache.carbondata.core.util.CarbonProperties
    +import org.apache.carbondata.core.util.path.{CarbonStorePath, CarbonTablePath}
    +import org.apache.carbondata.streaming.CarbonSparkStreamingListener
    +import org.apache.carbondata.streaming.parser.CarbonStreamParser
    +
    +/**
    + * This example introduces how to use Spark Streaming to write data
    + * to CarbonData stream table.
    + */
    +// scalastyle:off println
    +
    +case class StreamData(id: Int, name: String, city: String, salary: Float)
    --- End diff --
   
    "CarbonStreamSparkStreamingExample.scala" introduces how to use Spark Streaming to write data to stream table, and "CarbonBatchSparkStreamingExample" introduces how to use Spark Streaming to write data to batch loading table which  will auto compact segment. There are some different configurations and process flow, so I think using two examples is more clear.


---

[qiuchenjian-2]

Github user zzcclp commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1867#discussion_r164690569
 
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/CarbonStreamSparkStreamFactory.scala ---
    @@ -0,0 +1,58 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.sql
    +
    +import org.apache.commons.lang3.StringUtils
    +
    +import org.apache.carbondata.streaming.CarbonStreamException
    +import org.apache.carbondata.streaming.CarbonStreamSparkStreaming
    +import org.apache.carbondata.streaming.CarbonStreamSparkStreamingWriter
    +
    +/**
    + * Create CarbonStreamSparkStreamingWriter for stream table
    + * when integrate with Spark Streaming
    + */
    +object CarbonStreamSparkStreamFactory {
    --- End diff --
   
    OK, I will change it.


---