GitHub user sraghunandan opened a pull request:
https://github.com/apache/carbondata/pull/1871 [CARBONDATA-2089]SQL exception is masked due to assert(false) inside try catch and exception always asserting true
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [ x] Any interfaces changed?
No
- [ x] Any backward compatibility impacted?
No
- [x ] Document update required?
No
- [x ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.
Test cases have been corrected
- [ x] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
NA
You can merge this pull request into a Git repository by running:
$ git pull
https://github.com/sraghunandan/carbondata-1 correct_try_catch_in_sdv
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/1871.patchTo close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1871
----
commit e9c62a4ff1fe76b8343dbaf62a5573afea0348ad
Author: Raghunandan S <carbondatacontributions@...>
Date: 2018-01-27T15:19:47Z
SQL exception is masked due to assert(false) inside try catch and exception always asserting true
----
---
Locked
