[GitHub] carbondata pull request #1885: [CARBONDATA-2097] Restriction added to partit...

[qiuchenjian-2]

GitHub user kushalsaha opened a pull request:

    https://github.com/apache/carbondata/pull/1885

    [CARBONDATA-2097] Restriction added to partition table on alter command (add and rename)

    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [ ] Any interfaces changed?
     No
     - [ ] Any backward compatibility impacted?
     No
     - [ ] Document update required?
    No
     - [ ] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           Yes
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kushalsaha/carbondata visionIssue

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1885.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1885
   
----
commit 86ea1059864fdc9742c8cf2d22245cde2bdcb355
Author: akashrn5 <akashnilugal@...>
Date:   2018-01-24T08:56:28Z

    while submiting new job, pass credentials in jobConf object

commit cce7674739ad7d6115d14008e192d7c9bd0850e6
Author: kushalsaha <kushalsaha1988@...>
Date:   2018-01-30T11:08:47Z

    [CARBONDATA-2097] Restriction added to partition table on alter command

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1885
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2033/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1885
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3269/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1885
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3276/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1885
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2041/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1885
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3224/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1885
 
    retest sdv please


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1885
 
    LGTM


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1885
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3231/



---

[qiuchenjian-2]

Github user manishgupta88 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1885#discussion_r164956772
 
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/strategy/DDLStrategy.scala ---
    @@ -249,6 +249,27 @@ class DDLStrategy(sparkSession: SparkSession) extends SparkStrategy {
             ExecutedCommandExec(
               CarbonAlterTableUnsetCommand(tableName, propKeys, ifExists, isView)) :: Nil
           }
    +      case rename@AlterTableRenamePartitionCommand(tableName, oldPartition, newPartition) =>
    +        val dbOption = tableName.database.map(_.toLowerCase)
    +        val tableIdentifier = TableIdentifier(tableName.table.toLowerCase(), dbOption)
    +        val isCarbonTable = CarbonEnv.getInstance(sparkSession).carbonMetastore
    +          .tableExists(tableIdentifier)(sparkSession)
    +        if (isCarbonTable) {
    +          throw new UnsupportedOperationException("Renaming partition on table is not supported")
    +        } else {
    +          ExecutedCommandExec(rename) :: Nil
    +          }
    --- End diff --
   
    correct the code alignment


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1885
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3237/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1885
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2078/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1885
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3315/



---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/1885


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1885
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3249/



---