Apache CarbonData Dev Mailing List archive › Apache CarbonData JIRA issues

[GitHub] carbondata pull request #1891: [CARBONDATA-2104] ADD test for concurrent exe...

Classic

List

Threaded

31 messages Options

qiuchenjian-2

[GitHub] carbondata pull request #1891: [CARBONDATA-2104] ADD test for concurrent exe...

GitHub user jackylk opened a pull request:

https://github.com/apache/carbondata/pull/1891

[CARBONDATA-2104] ADD test for concurrent execution of insert overwrite and other command

1. More testcases are added for concurrent execution of insert overwrite and other commands.
2. Fix bug of delete segment, clean file when insert overwrite in progress
3. Change in all command processMetadata to throw ProcessMetadataException instead of `sys.error`

- [ ] Any interfaces changed?

- [ ] Any backward compatibility impacted?

- [ ] Document update required?

- [ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.

- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jackylk/incubator-carbondata add_concurrent_test

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/carbondata/pull/1891.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1891

----
commit 2eb19b9dfa337e1b3101752a72e49113686781b1
Author: Jacky Li <jacky.likun@...>
Date: 2018-01-31T05:10:11Z

add test for concurrent

----

---

qiuchenjian-2

[GitHub] carbondata pull request #1891: [CARBONDATA-2104] ADD test for concurrent exe...

Github user jackylk commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/1891#discussion_r164954583

--- Diff: integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/concurrent/TestLoadTableConcurrentScenario.scala ---
@@ -1,78 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-package org.apache.carbondata.spark.testsuite.concurrent
-
-import org.apache.carbondata.core.metadata.schema.table.CarbonTable
-import org.apache.carbondata.core.statusmanager.{SegmentStatus, SegmentStatusManager}
-import org.apache.spark.sql.CarbonEnv
-import org.apache.spark.sql.test.util.QueryTest
-import org.scalatest.BeforeAndAfterAll
-
-class TestLoadTableConcurrentScenario extends QueryTest with BeforeAndAfterAll {
--- End diff --

This suite moved to TestInsertAndOtherCommandConcurrent.scala

---

qiuchenjian-2