[GitHub] carbondata pull request #1899: [CARBONDATA-2109]make configs of dataframe lo...

[qiuchenjian-2]

GitHub user qiuchenjian opened a pull request:

    https://github.com/apache/carbondata/pull/1899

    [CARBONDATA-2109]make configs of dataframe load with tempCSV valid ,such as QUOTECHAR

    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [ ] Any interfaces changed?
     No
     - [ ] Any backward compatibility impacted?
     No
     - [ ] Document update required?
    No
     - [ ] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           Y
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
    NA


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/qiuchenjian/carbondata master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1899.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1899
   
----
commit fb7f72ec3413047c1edda1705d84ccf0d913353e
Author: qiuchenjian <807169000@...>
Date:   2018-01-15T14:47:24Z

    modify default config: change the default of tempCSV to false
    qiuchenjian

commit f32589096f478d9c1f260ee2e6ce4d77ff8ca86a
Author: qiuchenjian <807169000@...>
Date:   2018-01-31T14:16:14Z

    [CARBONDATA-2109]make configs of dataframe load with tempCSV valid ,such as QUOTECHAR

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1899
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3350/



---

[qiuchenjian-2]

Github user qiuchenjian commented on the issue:

    https://github.com/apache/carbondata/pull/1899
 
    retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1899
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3378/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1899
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2141/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1899
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3276/



---

[qiuchenjian-2]

Github user xuchuanyin commented on the issue:

    https://github.com/apache/carbondata/pull/1899
 
    No need to fix this. I think the 'tempCSV' option has other underlying problems, so it's better to deprecate this option. Pls refer to [CARBONDATA-2110](https://issues.apache.org/jira/browse/CARBONDATA-2110).


---

[qiuchenjian-2]

Github user qiuchenjian commented on the issue:

    https://github.com/apache/carbondata/pull/1899
 
    @xuchuanyin , I agree, this 'tempCSV' option has serveral bugs to fix


---

[qiuchenjian-2]

Github user qiuchenjian commented on the issue:

    https://github.com/apache/carbondata/pull/1899
 
    retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1899
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2181/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1899
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3419/



---

[qiuchenjian-2]

Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/1899
 
    Please close this PR if not required


---

[qiuchenjian-2]

Github user qiuchenjian closed the pull request at:

    https://github.com/apache/carbondata/pull/1899


---