[GitHub] carbondata pull request #1900: [HOTFIX] Correct the order of dropping pre-ag...

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #1900: [HOTFIX] Correct the order of dropping pre-ag...

qiuchenjian-2
GitHub user sraghunandan opened a pull request:

    https://github.com/apache/carbondata/pull/1900

    [HOTFIX] Correct the order of dropping pre-aggregate tables.pre-aggregate tables to be dropped before main table is dropped

   
    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [x] Any interfaces changed?
     No
     - [x] Any backward compatibility impacted?
     No
     - [x] Document update required?
    No
     - [x] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
         Test case corrected  
     - [x] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
    NA

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sraghunandan/carbondata-1 correct_ut_pre-agg_drop

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1900.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1900
   
----
commit 1ec2d07222f722e79ae8b5c73738e5b0b8854ca6
Author: Raghunandan S <carbondatacontributions@...>
Date:   2018-02-01T02:12:09Z

    [HOTFIX] Correct the order of dropping pre-aggregate tables.pre-aggregate tables to be dropped before main table is dropped

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1900: [HOTFIX] Correct the order of dropping pre-aggregate...

qiuchenjian-2
Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/1900
 
    LGTM, I will merge this now otherwise all CI will fail


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #1900: [HOTFIX] Correct the order of dropping pre-ag...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/1900


---