[GitHub] carbondata pull request #1914: [CARBONDATA-2122] Corrected bad record path v...

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1914
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3325/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1914
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3328/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1914
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3332/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1914
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3470/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1914
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2230/



---

[qiuchenjian-2]

Github user manishgupta88 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1914#discussion_r165809266
 
    --- Diff: integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/badrecordloger/BadRecordActionTest.scala ---
    @@ -92,6 +92,65 @@ class BadRecordActionTest extends QueryTest with BeforeAndAfterAll  {
           Seq(Row(2)))
       }
     
    +  test("test bad record REDIRECT but not having location should throw exception") {
    +    sql("drop table if exists sales")
    +    sql(
    +      """CREATE TABLE IF NOT EXISTS sales(ID BigInt, date Timestamp, country String,
    +          actual_price Double, Quantity int, sold_price Decimal(19,2)) STORED BY 'carbondata'""")
    +    val exMessage = intercept[Exception] {
    +      sql("LOAD DATA local inpath '" + csvFilePath + "' INTO TABLE sales OPTIONS" +
    +          "('bad_records_action'='REDIRECT', 'DELIMITER'=" +
    +          " ',', 'QUOTECHAR'= '\"', 'BAD_RECORD_PATH'='')")
    +    }
    +    assert(exMessage.getMessage.contains("Invalid bad records location."))
    +  }
    +
    +  test("test bad record REDIRECT but not having empty location in option should throw exception") {
    +    CarbonProperties.getInstance().addProperty(CarbonCommonConstants.CARBON_BADRECORDS_LOC,
    +      CarbonCommonConstants.CARBON_BADRECORDS_LOC_DEFAULT_VAL)
    +    sql("drop table if exists sales")
    +    sql(
    +      """CREATE TABLE IF NOT EXISTS sales(ID BigInt, date Timestamp, country String,
    +          actual_price Double, Quantity int, sold_price Decimal(19,2)) STORED BY 'carbondata'""")
    +    val exMessage = intercept[Exception] {
    +      sql("LOAD DATA local inpath '" + csvFilePath + "' INTO TABLE sales OPTIONS" +
    +          "('bad_records_action'='REDIRECT', 'DELIMITER'=" +
    +          " ',', 'QUOTECHAR'= '\"')")
    +    }
    +    assert(exMessage.getMessage.contains("Invalid bad records location."))
    +  }
    +
    +  test("test bad record is REDIRECT with location in carbon properties should pass") {
    +    sql("drop table if exists sales")
    +    CarbonProperties.getInstance().addProperty(CarbonCommonConstants.CARBON_BADRECORDS_LOC, "/tmp")
    --- End diff --
   
    Change /tmp to resourcesPath  in all your test cases


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1914
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3338/



---

[qiuchenjian-2]

Github user manishgupta88 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1914#discussion_r165812799
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/util/CarbonUtil.java ---
    @@ -1891,7 +1892,12 @@ public static boolean validateValidIntType(String value) {
        * @return
        */
       public static boolean isValidBadStorePath(String badRecordsLocation) {
    -    return !(null == badRecordsLocation || badRecordsLocation.length() == 0);
    +    if (StringUtils.isEmpty(badRecordsLocation)) {
    +      return false;
    +    }
    +    else {
    --- End diff --
   
    move else in above line


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1914
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3489/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1914
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2251/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1914
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2258/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1914
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2262/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1914
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3499/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1914
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3348/



---

[qiuchenjian-2]

Github user brijoobopanna commented on the issue:

    https://github.com/apache/carbondata/pull/1914
 
    retest this please



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1914
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2264/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1914
 
    retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1914
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3502/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1914
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3352/



---

[qiuchenjian-2]

Github user brijoobopanna commented on the issue:

    https://github.com/apache/carbondata/pull/1914
 
    retest this please



---