[GitHub] carbondata pull request #1936: [CARBONDATA-2135] Documentation for Table com...

[qiuchenjian-2]

GitHub user sgururajshetty opened a pull request:

    https://github.com/apache/carbondata/pull/1936

    [CARBONDATA-2135] Documentation for Table comment and Column Comment

    Documentation for table comment and column comment

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sgururajshetty/carbondata 2135

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1936.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1936
   
----
commit c78d3a56f209dea3259e0af147a96641de4e9c0f
Author: sgururajshetty <sgururajshetty@...>
Date:   2018-02-06T10:36:42Z

    Documentation for Table comment and Column Comment

----


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1936
 
    Can one of the admins verify this patch?


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1936
 
    Can one of the admins verify this patch?


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1936
 
    Can one of the admins verify this patch?


---

[qiuchenjian-2]

Github user sgururajshetty commented on the issue:

    https://github.com/apache/carbondata/pull/1936
 
    @chenliang613 kindly review
   



---

[qiuchenjian-2]

Github user manishgupta88 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1936#discussion_r170418767
 
    --- Diff: docs/data-management-on-carbondata.md ---
    @@ -286,7 +286,40 @@ This tutorial is going to introduce all commands and data operations on CarbonDa
       * If the table is aggregate table, then all the aggregate tables should be copied to the new database location.
       * For old store, the time zone of the source and destination cluster should be same.
       * If old cluster used HIVE meta store to store schema, refresh will not work as schema file does not exist in file system.
    +
    +### Table and Column Comment
    +
    +  You can provide more information on table by using table comment; similarly you can provide more information about a particular column using column comment.
    --- End diff --
   
    Use dot in place of semicolon


---

[qiuchenjian-2]

Github user manishgupta88 commented on the issue:

    https://github.com/apache/carbondata/pull/1936
 
    LGTM


---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/1936


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1936
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2623/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1936
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3868/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1936
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3649/



---