[GitHub] carbondata pull request #1942: [CARBONDATA-2136] Fixed bug related to data l...

[qiuchenjian-2]

GitHub user geetikagupta16 opened a pull request:

    https://github.com/apache/carbondata/pull/1942

    [CARBONDATA-2136] Fixed bug related to data load for bad_record_action as REDIRECT or IGNORE and sort scope as NO_SORT

    1. Refactored code for creating carbon row batch for bad_record_action as REDIRECT or IGNORE and sort scope as NO_SORT
    2. Added related test cases
   
    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
   
     - [ ] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/geetikagupta16/incubator-carbondata CARBONDATA-2136

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1942.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1942
   
----
commit 06de5ea9bcae5e60b22ee9530306b6951a3b9e00
Author: Geetika Gupta <geetika.gupta@...>
Date:   2018-02-07T10:42:09Z

    1. Refactored code for creating carbon row batch for bad_record_action as REDIRECT or IGNORE and sort scope as NO_SORT
    2. Added related test cases

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1942
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2320/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1942
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3557/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1942
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3558/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1942
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2321/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1942
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3563/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1942
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2326/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1942
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3399/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1942
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3400/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1942
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3406/



---

[qiuchenjian-2]

Github user sraghunandan commented on the issue:

    https://github.com/apache/carbondata/pull/1942
 
    @geetikagupta16 pls update the PR template


---

[qiuchenjian-2]

Github user geetikagupta16 commented on the issue:

    https://github.com/apache/carbondata/pull/1942
 
    @sraghunandan I have updated the PR template please check.


---

[qiuchenjian-2]

Github user mohammadshahidkhan commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1942#discussion_r168395269
 
    --- Diff: processing/src/main/java/org/apache/carbondata/processing/loading/steps/DataConverterProcessorStepImpl.java ---
    @@ -100,10 +103,17 @@ public void initialize() throws IOException {
        * @return processed row.
        */
       protected CarbonRowBatch processRowBatch(CarbonRowBatch rowBatch, RowConverter localConverter) {
    +    String badRecordsAction = (String) configuration.getDataLoadProperty(BAD_RECORDS_LOGGER_ACTION);
         while (rowBatch.hasNext()) {
           CarbonRow convertRow = localConverter.convert(rowBatch.next());
    -      rowBatch.setPreviousRow(convertRow);
    +      if (convertRow == null && (badRecordsAction.equals(LoggerAction.IGNORE.toString()) ||
    +          badRecordsAction.equals(LoggerAction.REDIRECT.toString()))) {
    --- End diff --
   
    @geetikagupta16 and @QiangCai
    In case of bucketing and Stream Record writer also the same exist.
    Please correct there as well.
    For your reference:
    1.  For  bucketing.
     org/apache/carbondata/processing/loading/steps/DataConverterProcessorWithBucketingStepImpl.java:128
    2. For Stream Record Writer
    org/apache/carbondata/hadoop/streaming/CarbonStreamRecordWriter.java:191


---

[qiuchenjian-2]

Github user mohammadshahidkhan commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1942#discussion_r168394055
 
    --- Diff: processing/src/main/java/org/apache/carbondata/processing/loading/steps/DataConverterProcessorStepImpl.java ---
    @@ -100,10 +103,17 @@ public void initialize() throws IOException {
        * @return processed row.
        */
       protected CarbonRowBatch processRowBatch(CarbonRowBatch rowBatch, RowConverter localConverter) {
    +    String badRecordsAction = (String) configuration.getDataLoadProperty(BAD_RECORDS_LOGGER_ACTION);
         while (rowBatch.hasNext()) {
           CarbonRow convertRow = localConverter.convert(rowBatch.next());
    -      rowBatch.setPreviousRow(convertRow);
    +      if (convertRow == null && (badRecordsAction.equals(LoggerAction.IGNORE.toString()) ||
    +          badRecordsAction.equals(LoggerAction.REDIRECT.toString()))) {
    --- End diff --
   
    Please remove check (badRecordsAction.equals(LoggerAction.IGNORE.toString()) ||
               badRecordsAction.equals(LoggerAction.REDIRECT.toString())
    BadRecordsAction check is not required, only null check over convertRow is enough.
    The convert method return's null only in case of bad_records_action is either IGNORE or REDIRECT.



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1942
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3748/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1942
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2508/



---

[qiuchenjian-2]

Github user geetikagupta16 commented on the issue:

    https://github.com/apache/carbondata/pull/1942
 
    @mohammadshahidkhan I have made the changes for bucketing. Please review


---

[qiuchenjian-2]

Github user mohammadshahidkhan commented on the issue:

    https://github.com/apache/carbondata/pull/1942
 
    @geetikagupta16  
    Please handle the same issue in case of  Stream Record writer as well.
    Currently there no test case for the bucketing flow to validate the issue handled as part of this PR.
    Please add the test cases to verify the bucketing and also streaming flow.


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1942
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3842/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1942
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2597/



---