[GitHub] carbondata pull request #1943: [CARBONDATA-2142] Fixed Pre-Aggregate datamap...

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #1943: [CARBONDATA-2142] Fixed Pre-Aggregate datamap...

qiuchenjian-2
GitHub user kumarvishal09 opened a pull request:

    https://github.com/apache/carbondata/pull/1943

    [CARBONDATA-2142] Fixed Pre-Aggregate datamap creation issue

    1. Fixed Reverting changes issue in case of create pre-aggregate data… map creation is failing
    2. Removed look-up while creating the pre-aggregate data map
    3. Removed unused code
   
    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
   
     - [ ] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kumarvishal09/incubator-carbondata master_5_

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1943.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1943
   
----
commit 47c0c2d37caa69e6cb6c207a8bf3ae0729fa0b31
Author: kumarvishal <kumarvishal.1802@...>
Date:   2018-02-05T09:47:02Z

    1. Fixed Reverting changes issue in case of create pre-aggregate data map creation is failing
    2. Removed look-up while creating the pre-aggregate data map
    3. Removed unused code

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1943: [CARBONDATA-2142] Fixed Pre-Aggregate datamap creati...

qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1943
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3559/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1943: [CARBONDATA-2142] Fixed Pre-Aggregate datamap creati...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1943
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2322/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1943: [CARBONDATA-2142] Fixed Pre-Aggregate datamap creati...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1943
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3401/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1943: [CARBONDATA-2142] Fixed Pre-Aggregate datamap creati...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1943
 
    LGTM


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #1943: [CARBONDATA-2142] Fixed Pre-Aggregate datamap...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/1943


---