[GitHub] carbondata pull request #1944: [Documentation] Added a FAQ for executor retu...

[qiuchenjian-2]

GitHub user sgururajshetty opened a pull request:

    https://github.com/apache/carbondata/pull/1944

    [Documentation] Added a FAQ for executor returning successful even after the query fa…

    dded a FAQ for executor returning successful even after the query failed

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sgururajshetty/carbondata faq1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1944.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1944
   
----
commit d32c887b4b683c2cdd4160bf9552e64f706a654c
Author: sgururajshetty <sgururajshetty@...>
Date:   2018-02-07T11:24:57Z

    Added a FAQ for executor returning successful even after the query failed

commit 411267affcfec7e6e6955de9435adfc9bb4497d9
Author: sgururajshetty <sgururajshetty@...>
Date:   2018-02-07T11:27:54Z

    Fixed a link issue

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1944
 
    Can one of the admins verify this patch?


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1944
 
    Can one of the admins verify this patch?


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1944
 
    Can one of the admins verify this patch?


---

[qiuchenjian-2]

Github user sraghunandan commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1944#discussion_r166603209
 
    --- Diff: docs/faq.md ---
    @@ -178,4 +179,9 @@ create datamap ag1 on table gdp21 using 'preaggregate' as select cntry, sum(gdp)
     select cntry,sum(gdp) from gdp21,pop1 where cntry=ctry group by cntry;
     ```
     
    +## Why all executors are returning success even after some of the query failed?
    --- End diff --
   
    language is not correct. its not a query, it a command.We need to say why executor does not retry and why the signal sent to driver is not interpreted as failed


---

[qiuchenjian-2]

Github user sgururajshetty commented on the issue:

    https://github.com/apache/carbondata/pull/1944
 
    @sraghunandan kindly review


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1944
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3037/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1944
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4281/



---

[qiuchenjian-2]

Github user sgururajshetty commented on the issue:

    https://github.com/apache/carbondata/pull/1944
 
    Closed as this FAQ is not needed


---

[qiuchenjian-2]

Github user sgururajshetty closed the pull request at:

    https://github.com/apache/carbondata/pull/1944


---