[GitHub] carbondata pull request #1964: [WIP][CARBONDATA2154] Carbon should support m...

[qiuchenjian-2]

GitHub user xubo245 opened a pull request:

    https://github.com/apache/carbondata/pull/1964

    [WIP][CARBONDATA2154] Carbon should support match pre-aggregate table when set carbon.input.segment...=*

   
   
    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
   
     - [ ] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/xubo245/carbondata CARBONDATA2154_SupportPreAggTable

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1964.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1964
   
----
commit 8b4c3fdfc5e3444280ef2c5dce1babed0614cfb3
Author: xubo245 <601450868@...>
Date:   2018-02-09T10:17:38Z

    [CARBONDATA2154] Carbon should support match pre-aggregate table when set carbon.input.segment...=*

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1964
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3646/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1964
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2407/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1964
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3647/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1964
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3484/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1964
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2408/



---

[qiuchenjian-2]

Github user chenliang613 commented on the issue:

    https://github.com/apache/carbondata/pull/1964
 
    @xubo245  why need to support this scenario ?


---

[qiuchenjian-2]

Github user xubo245 commented on the issue:

    https://github.com/apache/carbondata/pull/1964
 
    Because user can query all segments of main table when set carbon.input.segment...=*, it is similar to no set this parameter. So I think we should support this scenario.
   
      @sraghunandan  and @QiangCai  also agree this idea.


---

[qiuchenjian-2]

Github user xubo245 closed the pull request at:

    https://github.com/apache/carbondata/pull/1964


---