[GitHub] carbondata pull request #1985: [CARBONDATA-2185]add InputMetrics for Streami...

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #1985: [CARBONDATA-2185]add InputMetrics for Streami...

qiuchenjian-2
GitHub user BJangir opened a pull request:

    https://github.com/apache/carbondata/pull/1985

    [CARBONDATA-2185]add InputMetrics for Streaming Reader

    Issue:- Record count in Input Metrics is always 0 for Stream Reader.
   
    Solution :- InputMetricsStats object need to update for StreamReader with Record size . Also Need to handle when enableVector=false
   
    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [ ] Any interfaces changed?
     NA
     - [ ] Any backward compatibility impacted?
     NA
     - [ ] Document update required?
    NA
     - [ ] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
               Manual Verification is done,since value displayed in SparkUI
            - How it is tested? Please attach test report.
             Manual Verification done
            - Is it a performance related change? Please attach the performance test report.
    NA
            - Any additional information to help reviewers in testing this change.
           NA
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
      NA


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/BJangir/incubator-carbondata CARBONDATA-2185

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1985.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1985
   
----
commit 97f5d89d2d9432725ee5f532099a59cc43ac3943
Author: BJangir <babulaljangir111@...>
Date:   2018-02-19T17:01:00Z

    add InputMetrics for Streaming Reader

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1985: [CARBONDATA-2185]add InputMetrics for Streaming Read...

qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1985
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3772/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1985: [CARBONDATA-2185]add InputMetrics for Streaming Read...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1985
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2527/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1985: [CARBONDATA-2185]add InputMetrics for Streaming Read...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1985
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3558/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1985: [CARBONDATA-2185]add InputMetrics for Streaming Read...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user QiangCai commented on the issue:

    https://github.com/apache/carbondata/pull/1985
 
    LGTM


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #1985: [CARBONDATA-2185]add InputMetrics for Streami...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/1985


---