[GitHub] carbondata pull request #1987: [WIP] Add DataMap developer interface

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1987
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2590/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1987
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3838/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1987
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2593/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1987
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3621/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1987
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3623/



---

[qiuchenjian-2]

Github user QiangCai commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1987#discussion_r170206534
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/datamap/DataMapStoreManager.java ---
    @@ -142,46 +142,45 @@ public TableDataMap getDataMap(AbsoluteTableIdentifier identifier, DataMapSchema
        * The datamap is created using datamap name, datamap factory class and table identifier.
        */
       public TableDataMap createAndRegisterDataMap(AbsoluteTableIdentifier identifier,
    -      DataMapSchema dataMapSchema)
    -      throws MalformedDataMapCommandException {
    +      DataMapSchema dataMapSchema) throws MalformedDataMapCommandException {
    +    IndexDataMapFactory indexDataMapFactory;
    +    try {
    +      // try to create datamap by reflection to test whether it is a valid IndexDataMapFactory class
    +      Class<? extends IndexDataMapFactory> factoryClass =
    +          (Class<? extends IndexDataMapFactory>) Class.forName(dataMapSchema.getClassName());
    +      indexDataMapFactory = factoryClass.newInstance();
    +    } catch (ClassNotFoundException e) {
    +      throw new MalformedDataMapCommandException(
    +          "DataMap '" + dataMapSchema.getClassName() + "' not found");
    +    } catch (Throwable e) {
    +      throw new MetadataProcessException(
    +          "failed to create DataMap '" + dataMapSchema.getClassName() + "'", e);
    +    }
    +    return registerDataMap(identifier, dataMapSchema, indexDataMapFactory);
    +  }
    +
    +  public TableDataMap registerDataMap(AbsoluteTableIdentifier identifier,
    --- End diff --
   
    use private modifier


---

[qiuchenjian-2]

Github user QiangCai commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1987#discussion_r170197506
 
    --- Diff: integration/spark2/src/main/java/org/apache/carbondata/datamap/DataMapManager.java ---
    @@ -0,0 +1,53 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.carbondata.datamap;
    +
    +import org.apache.carbondata.core.metadata.schema.table.DataMapSchema;
    +
    +import static org.apache.carbondata.core.metadata.schema.datamap.DataMapProvider.PREAGGREGATE;
    +import static org.apache.carbondata.core.metadata.schema.datamap.DataMapProvider.TIMESERIES;
    +
    +public class DataMapManager {
    +
    +  private static DataMapManager INSTANCE;
    +
    +  private DataMapManager() { }
    +
    +  public static DataMapManager get() {
    --- End diff --
   
    add synchronized


---

[qiuchenjian-2]

Github user QiangCai commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1987#discussion_r170226147
 
    --- Diff: integration/spark2/src/main/java/org/apache/carbondata/datamap/TimeseriesDataMapProvider.java ---
    @@ -0,0 +1,47 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.carbondata.datamap;
    +
    +import java.util.Map;
    +
    +import org.apache.carbondata.core.metadata.schema.table.CarbonTable;
    +import org.apache.carbondata.core.metadata.schema.table.DataMapSchema;
    +
    +import org.apache.spark.sql.SparkSession;
    +import org.apache.spark.sql.execution.command.preaaggregate.PreAggregateTableHelper;
    +import org.apache.spark.sql.execution.command.timeseries.TimeSeriesUtil;
    +import scala.Tuple2;
    +
    +public class TimeseriesDataMapProvider extends PreAggregateDataMapProvider {
    --- End diff --
   
    add interface annotation


---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1987#discussion_r170245271
 
    --- Diff: integration/spark2/src/main/java/org/apache/carbondata/datamap/DataMapManager.java ---
    @@ -0,0 +1,53 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.carbondata.datamap;
    +
    +import org.apache.carbondata.core.metadata.schema.table.DataMapSchema;
    +
    +import static org.apache.carbondata.core.metadata.schema.datamap.DataMapProvider.PREAGGREGATE;
    +import static org.apache.carbondata.core.metadata.schema.datamap.DataMapProvider.TIMESERIES;
    +
    +public class DataMapManager {
    +
    +  private static DataMapManager INSTANCE;
    +
    +  private DataMapManager() { }
    +
    +  public static DataMapManager get() {
    --- End diff --
   
    fixed


---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1987#discussion_r170245295
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/datamap/DataMapStoreManager.java ---
    @@ -142,46 +142,45 @@ public TableDataMap getDataMap(AbsoluteTableIdentifier identifier, DataMapSchema
        * The datamap is created using datamap name, datamap factory class and table identifier.
        */
       public TableDataMap createAndRegisterDataMap(AbsoluteTableIdentifier identifier,
    -      DataMapSchema dataMapSchema)
    -      throws MalformedDataMapCommandException {
    +      DataMapSchema dataMapSchema) throws MalformedDataMapCommandException {
    +    IndexDataMapFactory indexDataMapFactory;
    +    try {
    +      // try to create datamap by reflection to test whether it is a valid IndexDataMapFactory class
    +      Class<? extends IndexDataMapFactory> factoryClass =
    +          (Class<? extends IndexDataMapFactory>) Class.forName(dataMapSchema.getClassName());
    +      indexDataMapFactory = factoryClass.newInstance();
    +    } catch (ClassNotFoundException e) {
    +      throw new MalformedDataMapCommandException(
    +          "DataMap '" + dataMapSchema.getClassName() + "' not found");
    +    } catch (Throwable e) {
    +      throw new MetadataProcessException(
    +          "failed to create DataMap '" + dataMapSchema.getClassName() + "'", e);
    +    }
    +    return registerDataMap(identifier, dataMapSchema, indexDataMapFactory);
    +  }
    +
    +  public TableDataMap registerDataMap(AbsoluteTableIdentifier identifier,
    --- End diff --
   
    fixed


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1987
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2606/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1987
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3851/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1987
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3634/



---

[qiuchenjian-2]

Github user QiangCai commented on the issue:

    https://github.com/apache/carbondata/pull/1987
 
    LGTM


---

[qiuchenjian-2]

Github user jackylk closed the pull request at:

    https://github.com/apache/carbondata/pull/1987


---