[GitHub] carbondata pull request #1990: [CARBONDATA-2195] Add new test case for parti...

[qiuchenjian-2]

GitHub user xubo245 opened a pull request:

    https://github.com/apache/carbondata/pull/1990

    [CARBONDATA-2195] Add new test case for partition feature and optimize old test case

    Add new test case for partition feature and optimize old test case
    This PR only contains test case
   
    During optimize test case, find a bug and fix it in: https://github.com/apache/carbondata/pull/1989
    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
   
     - [ ] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/xubo245/carbondata StandardPartition

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1990.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1990
   
----
commit c09e2ecd0c361dde26879f10b710194fc2b3863e
Author: xubo245 <601450868@...>
Date:   2018-02-22T10:18:35Z

    [CARBONDATA-2195] Add new test case for partition feature and optimize old test case

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1990
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3816/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1990
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2572/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1990
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3606/



---

[qiuchenjian-2]

Github user xubo245 commented on the issue:

    https://github.com/apache/carbondata/pull/1990
 
    retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1990
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2583/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1990
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3827/



---

[qiuchenjian-2]

Github user anubhav100 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1990#discussion_r170196522
 
    --- Diff: integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/standardpartition/StandardPartitionTableQueryTestCase.scala ---
    @@ -242,11 +242,13 @@ class StandardPartitionTableQueryTestCase extends QueryTest with BeforeAndAfterA
     
       }
     
    -test("Creation of partition table should fail if the colname in table schema and partition column is same even if both are case sensitive"){
    -  intercept[Exception]{
    -    sql("CREATE TABLE uniqdata_char2(name char,id int) partitioned by (NAME char)stored by 'carbondata' ")
    +  test("Creation of partition table should fail if the colname in table schema and partition column is same even if both are case sensitive") {
    +    val e = intercept[AnalysisException] {
    +      sql("CREATE TABLE uniqdata_char2(name char,id int) partitioned by (NAME char)stored by 'carbondata' ")
    +    }
    +    //TODO: error message is improper
    +    assert(e.getMessage.contains("DataType char is not supported"))
    --- End diff --
   
    @xubo245  spark 2.1.0 supports creating table even if char data type is given with out digits
   
    scala> spark.sql("create table id(id char)");
    18/02/23 14:12:23 WARN HiveMetaStore: Location: file:/home/anubhav/Documents/phatak/spark-2.1/bin/spark-warehouse/id specified for non-external table:id
    res0: org.apache.spark.sql.DataFrame = []
   
    but not in spark 2.2.1
   
    cala> spark.sql("create table id(id char)");
    18/02/23 14:22:05 WARN ObjectStore: Failed to get database global_temp, returning NoSuchObjectException
    org.apache.spark.sql.catalyst.parser.ParseException:
    DataType char is not supported.(line 1, pos 19)
   
    so to make sure that test case works fine for both spark version  you can change the create table ddl to
   
    sql("CREATE TABLE uniqdata_char2(name char,id int) partitioned by (NAME char(1))stored by 'carbondata' ")
    the check for exception message
    Operation not allowed: Partition columns should not be specified in the schema: ["name"](line 1, pos 62)
   
    otherwise it will be passed for spark 2.1 .0 but not for spark 2.2.1


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1990
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2730/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1990
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3975/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1990
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3731/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1990
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2791/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1990
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4037/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1990
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4043/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1990
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2797/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1990
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4057/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1990
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2811/



---

[qiuchenjian-2]

Github user xubo245 commented on the issue:

    https://github.com/apache/carbondata/pull/1990
 
    @jackylk @QiangCai Please review it


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1990
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3753/



---

[qiuchenjian-2]

Github user xubo245 commented on the issue:

    https://github.com/apache/carbondata/pull/1990
 
    retest sdv please


---