Apache CarbonData Dev Mailing List archive › Apache CarbonData JIRA issues

[GitHub] carbondata pull request #2010: [CARBONDATA-2206] Fixed lucene datamap evalua...

Classic

List

Threaded

10 messages Options

qiuchenjian-2

[GitHub] carbondata pull request #2010: [CARBONDATA-2206] Fixed lucene datamap evalua...

GitHub user ravipesala opened a pull request:

https://github.com/apache/carbondata/pull/2010

[CARBONDATA-2206] Fixed lucene datamap evaluation issue in executor

In case of MatchExpression it should return same bitset from RowLevelFilterExecuterImpl

Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:

- [ ] Any interfaces changed?

- [ ] Any backward compatibility impacted?

- [ ] Document update required?

- [ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.

- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ravipesala/incubator-carbondata lucene-datamap-fix

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/carbondata/pull/2010.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2010

----
commit 761fc1c63bcf6932ed9b6c3242c5ae13555c6a28
Author: ravipesala <ravi.pesala@...>
Date: 2018-02-27T13:44:15Z

Changed match expression just like true expression so that it always returns true for row level executor in executors

----

---

qiuchenjian-2

[GitHub] carbondata pull request #2010: [CARBONDATA-2206] Fixed lucene datamap evalua...

Github user jackylk commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/2010#discussion_r170989135

--- Diff: core/src/main/java/org/apache/carbondata/core/scan/filter/executer/RowLevelFilterExecuterImpl.java ---
@@ -190,6 +191,9 @@ private void initMeasureChunkIndexes() {
@Override
public BitSetGroup applyFilter(RawBlockletColumnChunks rawBlockletColumnChunks,
boolean useBitsetPipeLine) throws FilterUnsupportedException, IOException {
+ if (exp instanceof MatchExpression) {
--- End diff --

after this change, please modify the testcase LuceneFineGrainDataMapSuite to assert the result

---

qiuchenjian-2