[GitHub] carbondata pull request #2019: [CARBONDATA-2172] Add text_columns property f...

[qiuchenjian-2]

GitHub user QiangCai opened a pull request:

    https://github.com/apache/carbondata/pull/2019

    [CARBONDATA-2172] Add text_columns property for Lucene DataMap

    **Modification**
    Add text_columns property for Lucene DataMap:
    ```SQL
     CREATE DATAMAP <dataMapName> ON TABLE <tableName>
     USING 'org.apache.carbondata.datamap.lucene.LuceneFineGrainDataMapFactory'
     DMProperties('TEXT_COLUMNS'='col1,col3')
    ```
    **Limitation**
    1. TEXT_COLUMNS only support String DataType columns
   
   
     - [x] Any interfaces changed?
     yes, add new datamap properties
     - [x] Any backward compatibility impacted?
     no
     - [x] Document update required?
    yes
     - [x] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
                 added ut
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [x] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
    small changes


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/QiangCai/carbondata datamap_lucene_text_columns

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2019.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2019
   
----
commit 3c91938f85484ae25f800763a148ab551ad312d3
Author: QiangCai <qiangcai@...>
Date:   2018-03-01T07:40:01Z

    add text_columns DataMap property

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2019
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4004/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2019
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2760/



---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2019#discussion_r171568091
 
    --- Diff: datamap/lucene/pom.xml ---
    @@ -96,6 +96,11 @@
           <artifactId>scalatest_${scala.binary.version}</artifactId>
           <scope>test</scope>
         </dependency>
    +    <dependency>
    +      <groupId>commons-lang</groupId>
    +      <artifactId>commons-lang</artifactId>
    +      <version>2.6</version>
    --- End diff --
   
    move this version definition to parent


---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2019#discussion_r171568299
 
    --- Diff: datamap/lucene/src/main/java/org/apache/carbondata/datamap/lucene/LuceneDataMapFactoryBase.java ---
    @@ -133,6 +120,44 @@ public void init(AbsoluteTableIdentifier identifier, DataMapSchema dataMapSchema
         analyzer = new StandardAnalyzer();
       }
     
    +  private List<String> validateAndGetIndexedColumns(DataMapSchema dataMapSchema,
    --- End diff --
   
    add comment, what is validated


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2019
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2773/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2019
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4017/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2019
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4021/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2019
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2777/



---

[qiuchenjian-2]

Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/2019
 
    LGTM


---

[qiuchenjian-2]

Github user QiangCai commented on the issue:

    https://github.com/apache/carbondata/pull/2019
 
    already merged


---

[qiuchenjian-2]

Github user QiangCai closed the pull request at:

    https://github.com/apache/carbondata/pull/2019


---