[GitHub] carbondata pull request #2023: [HOXFIX] Add show and drop datamap code

[qiuchenjian-2]

GitHub user chenliang613 opened a pull request:

    https://github.com/apache/carbondata/pull/2023

    [HOXFIX] Add show and drop datamap code

    Add show and drop datamap code. Update assemble pom for changing jar name.
   
    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [X] Any interfaces changed?
     NA
     - [X] Any backward compatibility impacted?
     NA
     - [X] Document update required?
    NA
     - [X] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [X] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
    NA


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/chenliang613/carbondata datamap

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2023.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2023
   
----
commit 8e747bc24574731ee3cbbdb9bf74ea959facb6df
Author: chenliang613 <chenliang613@...>
Date:   2018-03-02T13:33:05Z

    add show and drop datamap code

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2023
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4044/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2023
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2798/



---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2023#discussion_r172007572
 
    --- Diff: examples/spark2/src/main/scala/org/apache/carbondata/examples/PreAggregateDataMapExample.scala ---
    @@ -51,6 +51,7 @@ object PreAggregateTableExample {
            LOAD DATA LOCAL INPATH '$testData' into table mainTable
            """)
     
    +    // create datamaps of pre-aggregate
    --- End diff --
   
    better change to `create pre-aggregate table by datamap`


---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2023#discussion_r172007576
 
    --- Diff: examples/spark2/src/main/scala/org/apache/carbondata/examples/PreAggregateDataMapExample.scala ---
    @@ -101,7 +109,7 @@ object PreAggregateTableExample {
           .option("compress", "true")
           .mode(SaveMode.Overwrite).save()
     
    -    // Create pre-aggregate table
    +    // Create datamap of pre-aggregate
    --- End diff --
   
    change as above comment


---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2023#discussion_r172007591
 
    --- Diff: examples/spark2/src/main/scala/org/apache/carbondata/examples/PreAggregateDataMapExample.scala ---
    @@ -72,6 +73,13 @@ object PreAggregateTableExample {
              | select id,max(age) from mainTable group by id"""
             .stripMargin)
     
    +    // show datamap
    +    spark.sql("show datamap on table mainTable").show(false)
    +
    +    // drop datamap
    +    spark.sql("drop datamap preagg_count on table mainTable").show()
    +    spark.sql("show datamap on table mainTable").show(false)
    +
         spark.sql(
           s"""
              | SELECT id,max(age)
    --- End diff --
   
    since you are adding comment, can you add for query also, to describe which datamap it will hit


---

[qiuchenjian-2]

Github user chenliang613 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2023#discussion_r172036640
 
    --- Diff: examples/spark2/src/main/scala/org/apache/carbondata/examples/PreAggregateDataMapExample.scala ---
    @@ -51,6 +51,7 @@ object PreAggregateTableExample {
            LOAD DATA LOCAL INPATH '$testData' into table mainTable
            """)
     
    +    // create datamaps of pre-aggregate
    --- End diff --
   
    accept,fixed it.


---

[qiuchenjian-2]

Github user chenliang613 commented on the issue:

    https://github.com/apache/carbondata/pull/2023
 
    retest this please


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2023
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3751/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2023
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4064/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2023
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2818/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2023
 
    LGTM


---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/2023


---