[GitHub] carbondata pull request #2038: [WIP]Support UTF-8 with BOM in CSVInputFormat

[qiuchenjian-2]

GitHub user KanakaKumar opened a pull request:

    https://github.com/apache/carbondata/pull/2038

    [WIP]Support UTF-8 with BOM in CSVInputFormat

    Currently Hive table supports csv file with BOM encoding but Carbon table does not support.
     org.apache.hadoop.mapred.LineRecordReader handles the BOM bytes.
   
    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
   
     - [ ] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/KanakaKumar/carbondata bom_support

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2038.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2038
   
----
commit 905fe3721420b7d8f6b1d1537830ea321f48430e
Author: KanakaKumar <kanaka.avvaru@...>
Date:   2018-03-05T11:28:18Z

    Support UTF-8 with BOM in CSVInputFormat
   
    Part 2 of BOM fixes

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2038
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2873/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2038
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4118/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2038
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2876/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2038
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4122/



---

[qiuchenjian-2]

Github user KanakaKumar commented on the issue:

    https://github.com/apache/carbondata/pull/2038
 
    retest SDV please


---

[qiuchenjian-2]

Github user gvramana commented on the issue:

    https://github.com/apache/carbondata/pull/2038
 
    LGTM


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2038
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3783/



---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/2038


---