[GitHub] carbondata pull request #2045: [CARBONDATA-2230]Add a path into table path t...

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2045
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3917/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2045
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3919/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2045
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3921/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2045
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3923/



---

[qiuchenjian-2]

Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/2045
 
    LGTM


---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/2045


---

[qiuchenjian-2]

Github user akashrn5 commented on the issue:

    https://github.com/apache/carbondata/pull/2045
 
    @zzcclp i had configured the preserve time to 1hour, so after one hour i loaded the table again, but it didnt clean the lock files, when these lock files wll be deleted?


---

[qiuchenjian-2]

Github user zzcclp commented on the issue:

    https://github.com/apache/carbondata/pull/2045
 
    @akashrn5 It works fine on our env, if you configured the preserver time to 1 hour (carbon.segment.lock.files.preserve.hours=1), it will delete the **segment** lock files which the last modified time is older than 1 hour.
   
    But there are one scenario that it will not delete the segment lock files:
    there are some 'MARKED_FOR_DELETE' or 'COMPACTED' or 'INSERT_IN_PROGRESS' or ''INSERT_OVERWRITE_IN_PROGRESS' segments but the last modified time of these segments were all within 1 hour.
    Maybe we can delete the segment lock files before this check , @jackylk  @ravipesala what do you think about this? is it ok to do this?


---