[GitHub] carbondata pull request #2080: [CARBONDATA-2264] Support create table using ...

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2080#discussion_r176739906
 
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/CarbonSource.scala ---
    @@ -334,6 +334,11 @@ object CarbonSource {
         properties.foreach(e => map.put(e._1, e._2))
         map.put("tablepath", identifier.getTablePath)
         map.put("dbname", identifier.getDatabaseName)
    +    val LOGGER = LogServiceFactory.getLogService(this.getClass.getCanonicalName)
    --- End diff --
   
    move this inside if block


---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2080#discussion_r176740315
 
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/CarbonSource.scala ---
    @@ -334,6 +334,11 @@ object CarbonSource {
         properties.foreach(e => map.put(e._1, e._2))
         map.put("tablepath", identifier.getTablePath)
         map.put("dbname", identifier.getDatabaseName)
    +    val LOGGER = LogServiceFactory.getLogService(this.getClass.getCanonicalName)
    +    if (map.containsKey("tableName")) {
    +      LOGGER.warn("tableName is useless in option when create table")
    --- End diff --
   
    change to `tableName is not required in options, ignoring it`


---

[qiuchenjian-2]

Github user xubo245 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2080#discussion_r176897179
 
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/CarbonSource.scala ---
    @@ -334,6 +334,11 @@ object CarbonSource {
         properties.foreach(e => map.put(e._1, e._2))
         map.put("tablepath", identifier.getTablePath)
         map.put("dbname", identifier.getDatabaseName)
    +    val LOGGER = LogServiceFactory.getLogService(this.getClass.getCanonicalName)
    --- End diff --
   
    ok, done


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2080
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3329/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2080
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4555/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2080
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4053/



---

[qiuchenjian-2]

Github user xubo245 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2080#discussion_r176962510
 
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/CarbonSource.scala ---
    @@ -334,6 +334,11 @@ object CarbonSource {
         properties.foreach(e => map.put(e._1, e._2))
         map.put("tablepath", identifier.getTablePath)
         map.put("dbname", identifier.getDatabaseName)
    +    val LOGGER = LogServiceFactory.getLogService(this.getClass.getCanonicalName)
    +    if (map.containsKey("tableName")) {
    +      LOGGER.warn("tableName is useless in option when create table")
    --- End diff --
   
    ok,done


---

[qiuchenjian-2]

Github user xubo245 commented on the issue:

    https://github.com/apache/carbondata/pull/2080
 
    @jackylk done, please handle it.


---

[qiuchenjian-2]

Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/2080
 
    LGTM


---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/2080


---