[GitHub] carbondata pull request #2081: [CARBONDATA-2262] Support the syntax of 'usin...

[qiuchenjian-2]

Github user xubo245 commented on the issue:

    https://github.com/apache/carbondata/pull/2081
 
    retest sdv please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2081
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3399/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2081
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4624/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2081
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4128/



---

[qiuchenjian-2]

Github user xubo245 commented on the issue:

    https://github.com/apache/carbondata/pull/2081
 
    retest sdv please


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2081
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4129/



---

[qiuchenjian-2]

Github user xubo245 commented on the issue:

    https://github.com/apache/carbondata/pull/2081
 
    retest sdv please


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2081
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4136/



---

[qiuchenjian-2]

Github user xubo245 commented on the issue:

    https://github.com/apache/carbondata/pull/2081
 
    retest sdv please


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2081
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4144/



---

[qiuchenjian-2]

Github user xubo245 commented on the issue:

    https://github.com/apache/carbondata/pull/2081
 
    @jackylk @chenliang613 CI pass, Please check it.


---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2081#discussion_r177973231
 
    --- Diff: examples/spark2/src/main/scala/org/apache/carbondata/examples/SparkSessionExample.scala ---
    @@ -63,123 +63,126 @@ object SparkSessionExample {
     
         sparksession.sparkContext.setLogLevel("ERROR")
     
    -    // Create table
    -    sparksession.sql("DROP TABLE IF EXISTS sparksession_table")
    -    sparksession.sql(
    -      s"""
    -         | CREATE TABLE sparksession_table(
    -         | shortField SHORT,
    -         | intField INT,
    -         | bigintField LONG,
    -         | doubleField DOUBLE,
    -         | stringField STRING,
    -         | timestampField TIMESTAMP,
    -         | decimalField DECIMAL(18,2),
    -         | dateField DATE,
    -         | charField CHAR(5)
    -         | )
    -         | USING org.apache.spark.sql.CarbonSource
    -         | OPTIONS('DICTIONARY_INCLUDE'='dateField, charField',
    -         | 'dbName'='default', 'tableName'='sparksession_table')
    +    for (keyWord <- Array("org.apache.spark.sql.CarbonSource", "carbondata")) {
    --- End diff --
   
    I think this makes it more complex, just use `carbondata` is enough


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2081
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4651/



---

[qiuchenjian-2]

Github user xubo245 commented on the issue:

    https://github.com/apache/carbondata/pull/2081
 
    retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2081
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3424/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2081
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4654/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2081
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3427/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2081
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4161/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2081
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4162/



---

[qiuchenjian-2]

Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/2081
 
    LGTM


---